From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian =?iso-8859-1?q?Borntr=E4ger?= Date: Fri, 11 Feb 2005 17:41:23 +0000 Subject: Re: [ANNOUNCE] hotplug-ng 001 release Message-Id: <200502111841.24040.christian@borntraeger.net> MIME-Version: 1 Content-Type: multipart/mixed; boundary="Boundary-00=_E5ODCsIRfBWwfwg" List-Id: References: <20050211004033.GA26624@suse.de> In-Reply-To: <20050211004033.GA26624@suse.de> To: linux-hotplug@vger.kernel.org --Boundary-00=_E5ODCsIRfBWwfwg Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Greg KH wrote: > In fact, if anyone looking to contribute some well defined and easy to > test code... :) Well, lets start with a small bugfix. The agents segfault without a parameter. --Boundary-00=_E5ODCsIRfBWwfwg Content-Type: text/x-diff; charset="iso-8859-1"; name="segfault.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="segfault.patch" diff -Nurp hotplug-ng-001/module_form.c new/module_form.c --- hotplug-ng-001/module_form.c 2005-02-11 00:40:02.000000000 +0100 +++ new/module_form.c 2005-02-11 18:32:58.000000000 +0100 @@ -49,6 +49,10 @@ int main(int argc, char *argv[], char *e int retval = 1; \ \ logging_init("module_"#type); \ + if(argc == 1) { \ + dbg("this handler expects a parameter, aborting."); \ + goto exit; \ + } \ \ subsystem = argv[1]; \ if (strcmp(#type, subsystem) != 0) { \ --Boundary-00=_E5ODCsIRfBWwfwg-- ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel