linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: udev PROGRAM key and the device chain walk
Date: Sun, 13 Feb 2005 14:15:25 +0000	[thread overview]
Message-ID: <20050213141525.GA22956@vrfy.org> (raw)

While we try to match rule keys against a devices sysfs representaion,
we need to follow the physical device and walk up the device chain up to
the root device and match our rule against every device found.

While this is necessary to match the SYSFS and BUS keys, it has the
_very_ bad side effect, that a PROGRAM may be executed several times. In
my test setup, I've seen five executions of a callout to match one single
rule.

The only reason to do this, is the match with a callout against a sysfs
attribute of one of the physical devices along the chain by using
the %s{<attr>} key.
I don't think that this is really needed and I want to change the namedev
logic to execute the PROGRAM key only once per rule. It will be still
possible to pass the %s{<attr>} to the callout, but it will only happen
at the device itself and not follow the chain to the root device. If
such a thing is ever needed, the callout can do it itself and not rely on
udev to execute it several times.

Any objections, or I will change that to speed things up.

Thanks,
Kay


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

             reply	other threads:[~2005-02-13 14:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-13 14:15 Kay Sievers [this message]
2005-02-14 19:19 ` udev PROGRAM key and the device chain walk Greg KH
2005-02-15  0:55 ` Kay Sievers
2005-02-15  1:07 ` Greg KH
2005-02-15  1:47 ` Kay Sievers
2005-02-15 23:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050213141525.GA22956@vrfy.org \
    --to=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).