From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 14 Feb 2005 19:19:09 +0000 Subject: Re: udev PROGRAM key and the device chain walk Message-Id: <20050214191908.GA9891@kroah.com> List-Id: References: <20050213141525.GA22956@vrfy.org> In-Reply-To: <20050213141525.GA22956@vrfy.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Sun, Feb 13, 2005 at 03:15:25PM +0100, Kay Sievers wrote: > While we try to match rule keys against a devices sysfs representaion, > we need to follow the physical device and walk up the device chain up to > the root device and match our rule against every device found. > > While this is necessary to match the SYSFS and BUS keys, it has the > _very_ bad side effect, that a PROGRAM may be executed several times. In > my test setup, I've seen five executions of a callout to match one single > rule. Is this because the rule was written badly? > The only reason to do this, is the match with a callout against a sysfs > attribute of one of the physical devices along the chain by using > the %s{} key. > I don't think that this is really needed and I want to change the namedev > logic to execute the PROGRAM key only once per rule. It will be still > possible to pass the %s{} to the callout, but it will only happen > at the device itself and not follow the chain to the root device. If > such a thing is ever needed, the callout can do it itself and not rely on > udev to execute it several times. > > Any objections, or I will change that to speed things up. Again, is this really needed, or do we just blame it on a badly written rule? thanks, greg k-h ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel