From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 14 Feb 2005 22:42:08 +0000 Subject: Re: [ANNOUNCE] hotplug-ng 001 release Message-Id: <20050214224208.GC13110@suse.de> List-Id: References: <20050211004033.GA26624@suse.de> In-Reply-To: <20050211004033.GA26624@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Sat, Feb 12, 2005 at 03:34:58AM +0300, Roman Kagan wrote: > On Fri, Feb 11, 2005 at 01:10:28PM -0800, Greg KH wrote: > > If you look at the hotplug scripts, they really don't need to touch > > sysfs at all. (Note that the scsi one does, but I think we can fix the > > scsi hotplug event to solve this issue...) > > > > So module autoload has really nothing to do with sysfs. > > Just to make sure I understand what you mean: is the idea that hotplug > scripts get the device IDs through the environment variables only, and > the coldplug's responsibility is to fetch the info from sysfs and make > up the same set of environment variables to pass to hotplug? > > Then why not just make the kernel (and coldplug) create an additional > environment variable with the fnmatch-able module name ready to use with > modprobe? Given that kernel (and coldplug) have all the IDs in the nice > integer form it would be a matter of a single add_hotplug_env_var() (or > sprintf()) call per each device type, and would be even tinier that the > hotplug-ng :) You know, it's moments like this that I really think the open source development model is the best. People are able to look into a project and point out how stupid the original designers/authors are at any moment in time :) You are completly correct, I love your kernel patch. With it, and a few minor changes to modprobe, we don't need _any_ of the module_* programs in the hotplug-ng package I just released. That is wonderful, thank you so much for showing me that I was just working in circles. I'll go work on this in the next few days (getting over being sick and trying to catch up on email right now...) Thanks again, I really appreciate it. greg k-h ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel