From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sat, 26 Feb 2005 05:35:37 +0000 Subject: Re: event sequencing Message-Id: <20050226053537.GA11424@kroah.com> List-Id: References: <9e473391050225081838f673c7@mail.gmail.com> In-Reply-To: <9e473391050225081838f673c7@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Sat, Feb 26, 2005 at 06:08:17AM +0100, Kay Sievers wrote: > On Fri, 2005-02-25 at 19:58 -0800, Greg KH wrote: > >On Sat, Feb 26, 2005 at 04:43:23AM +0100, Kay Sievers wrote: > >> On Fri, 2005-02-25 at 19:29 -0800, Greg KH wrote: > >> >On Fri, Feb 25, 2005 at 05:53:27PM +0100, Kay Sievers wrote: > >> >> On Fri, 2005-02-25 at 11:18 -0500, Jon Smirl wrote: > >> >> >I working on adding hotplug monitor change detection code to some > >> >> >framebuffer drivers. I having trouble with event sequencing. > >> >> > > >> >> >In my probe function I do a class_simple_device_add() to create the > >> >> >class entry. Later in the probe function I do > >> >> >kobject_hotplug(&info->class_device->kobj, KOBJ_MOUNT); to indicate a > >> >> >monitor change. > >> >> > >> >> Don't use that function. It is only for the driver core. It will execute > >> >> a usermode_helper which is not the way to do new stuff. Use the netlink > >> >> events for that: If your application is some low-level stuff, listen > >> >> directly to uevents: > >> >> http://www.kernel.org/pub/linux/utils/kernel/hotplug/uevent_listen.c > >> >> > >> >> or if it's desktop stuff, add support to HAL for it. > >> > > >> >No, it's ok for him to call kobject_hotplug() for this type of event (we > >> >explicitly said it was ok to do so at the last kernel summit). > >> > >> So what about creating a class device for the monitor, which will be > >> created and removed? > > > >He already has a fb device, right? That's all that is needed. I don't > >see what the problem is with calling kevent_hotplug() for a valid > >kobject. What's the big objection? > > Cause it may be nice to add and remove a monitor device instead of a two > stage event for the same device with "change" actions. No big > objection. :) I'm just asking, cause it sounds like a monitor hotplug > event. Hm, I don't think the kernel knows about a "monitor", just a fb device. Right Jon? thanks, greg k-h ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel