linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 3/4] Fix -Wall warnings in udev 054 (chassis_id)
@ 2005-03-10 14:40 Tobias Klauser
  2005-03-10 17:52 ` Kay Sievers
  0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2005-03-10 14:40 UTC (permalink / raw)
  To: linux-hotplug

Hi,

The following patch fixes a warning when compiling chassis_id
from udev with the -Wall compiler flag. There are too much
conversions in the format string of sscanf(). One %d can be
dropped.

Thanks, Tobias

Signed-off-by: Tobias Klauser <tklauser@access.unizh.ch>

diff -urpN udev-054.orig/extras/chassis_id/table.c udev-054/extras/chassis_id/table.c
--- udev-054.orig/extras/chassis_id/table.c	2005-03-01 21:19:49.000000000 +0100
+++ udev-054/extras/chassis_id/table.c	2005-03-06 15:41:49.000000000 +0100
@@ -59,7 +59,7 @@ int table_init(void)
 	i = 0;
 	while (!feof(fp)) {
 		fgets(ptr, 80, fp);	
-		sscanf(ptr, "%d %d %d %d %d %s %s", &ptable[i].id,
+		sscanf(ptr, "%d %d %d %d %s %s", &ptable[i].id,
 			&ptable[i].num_disks, 
 			&ptable[i].chassis_num, &ptable[i].slot_num,
 			ptable[i].serial_num, ptable[i].name);



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/4] Fix -Wall warnings in udev 054 (chassis_id)
  2005-03-10 14:40 [PATCH 3/4] Fix -Wall warnings in udev 054 (chassis_id) Tobias Klauser
@ 2005-03-10 17:52 ` Kay Sievers
  0 siblings, 0 replies; 2+ messages in thread
From: Kay Sievers @ 2005-03-10 17:52 UTC (permalink / raw)
  To: linux-hotplug

On Thu, 2005-03-10 at 15:40 +0100, Tobias Klauser wrote:
> Hi,
> 
> The following patch fixes a warning when compiling chassis_id
> from udev with the -Wall compiler flag. There are too much
> conversions in the format string of sscanf(). One %d can be
> dropped.
> 
> Thanks, Tobias
> 
> Signed-off-by: Tobias Klauser <tklauser@access.unizh.ch>
> 
> diff -urpN udev-054.orig/extras/chassis_id/table.c udev-054/extras/chassis_id/table.c
> --- udev-054.orig/extras/chassis_id/table.c	2005-03-01 21:19:49.000000000 +0100
> +++ udev-054/extras/chassis_id/table.c	2005-03-06 15:41:49.000000000 +0100
> @@ -59,7 +59,7 @@ int table_init(void)
>  	i = 0;
>  	while (!feof(fp)) {
>  		fgets(ptr, 80, fp);	
> -		sscanf(ptr, "%d %d %d %d %d %s %s", &ptable[i].id,
> +		sscanf(ptr, "%d %d %d %d %s %s", &ptable[i].id,
>  			&ptable[i].num_disks, 
>  			&ptable[i].chassis_num, &ptable[i].slot_num,
>  			ptable[i].serial_num, ptable[i].name);

Applied.

Thanks,
Kay



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-03-10 17:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-10 14:40 [PATCH 3/4] Fix -Wall warnings in udev 054 (chassis_id) Tobias Klauser
2005-03-10 17:52 ` Kay Sievers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).