Re: Latest bk kernel does not properly free PCI IO & MEM allocations

[Greg KH <greg@kroah.com>]

On Fri, Mar 11, 2005 at 04:30:07PM -0500, Prarit Bhargava wrote:
> Hi Greg,
> 
> Greg KH wrote:
> 
> >pci_free_resources is not a legacy call, it's a function internal to the
> >pci core.
> > 
> >
> Sorry -- I read that back and realize how incorrect that was.
> 
> What I meant to say was pci_free_resources calls release_resource, where
> release_region calls __release_region.  __release_region is called a 
> "legacy" function?

What documentation calls it that?

> >Does the following patch fix the issue for you?
> >
> > 
> >
> Nope, because the res pointer still points to an "old" memory address -- 
> then the res value check succeeds and I would oops if res->parent was 
> NULL. (Haven't tried it but I think it will still die if SLAB debug is 
> on ...)
> 
> How about the attached patch?  (I think the warning is a bit wordy ... 
> if you have a better idea I'm all for it ... If you want to dump the 
> warning I'm fine with that too...)

I don't like the wording at all, no one will notice it (trust me I've
tried stuff like this before...)

But what's really curious, is why no one has hit this before.  Nothing
has changed recently in this area of the kernel.  Did this used to work
before?  Does it work just fine without the patch for other drivers?

thanks,

greg k-h


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel