Re: [PATCH] udev: add rule based program execution

[Roman Kagan <rkagan@mail.ru>]

On Tue, Mar 29, 2005 at 04:54:03PM +0200, Kay Sievers wrote:
> To get this working, I changed the logic to read all rules and not to
> stop at the first match.

That's very nice, indeed.

> If a rule should be the last one to be applied
> to a device it must use OPTION="last_rule".

IMHO this is going to increase admin's chances to shoot himself in the
foot.  Imagine someone having installed a rules file causing the
processing of a particular type to stop early, and then someone (else)
trying to figure out what's wrong with another rules file matching the
same devices but happening to go later in the list.

I beleive all rules must be independently processed; the only reason for
the user to care about the order of the rules should be when a rule
depends on the _results_ of the action of another rule.

As to the notorious "too many tty devices" problem, I guess it can be
worked around with something like

SUBSYSTEM="tty", NAME=""

or

SUBSYSTEM!="tty", HOTPLUG="/some/slow/hotplug/script"

> After the first rule that
> assigns a NAME to a device, all later rules with a NAME key will be
> ignored, so it should not change the current behavior too much.

Same problem here: changing the order of the (seemingly independent!)
rules may cause unexpected change of which rule applies.  What's wrong
with executing all NAME actions?  At worst it'll create multiple device
nodes for the same device - big deal...

Cheers,
  Roman.


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel