From mboxrd@z Thu Jan 1 00:00:00 1970 From: Han Boetes Date: Sun, 10 Apr 2005 10:27:07 +0000 Subject: Re: [klibc] not everybody uses bash Message-Id: <20050410102729.GA22814@boetes.org> List-Id: References: <20050408170525.GU15412@boetes.org> In-Reply-To: <20050408170525.GU15412@boetes.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org H. Peter Anvin wrote: > Han Boetes wrote: > > Though most people do have which installed somewhere. > > Denied. which has really bad properties on a lot of shells, and > unless you can trust "make" to invoke /usr/bin/which (or > whatever it happens to be), then you're screwed. > > The reason the script invokes bash explicitly is to deal with > people who *aren't* using bash as a shell. If people don't _have_ bash as a shell it won't work at all. Every shell I know has ``type foo'' and return something like ``foo is /usr/bin/foo'' --- Makefile.orig 2005-04-10 11:27:49.523924416 +0200 +++ Makefile 2005-04-10 11:53:34.390069064 +0200 @@ -18,12 +18,12 @@ echo 'ARCH=$(ARCH)' >> $@ echo 'CROSS=$(CROSS)' >> $@ echo 'KCROSS=$(KCROSS)' >> $@ - echo "CC=$(shell bash -c 'type -p $(CC)')" >> $@ - echo "LD=$(shell bash -c 'type -p $(LD)')" >> $@ + echo "CC=$(shell /bin/sh -c 'type $(CC)|sed "s,.* ,,"')" >> $@ + echo "LD=$(shell /bin/sh -c 'type $(LD)|sed "s,.* ,,"')" >> $@ echo 'REQFLAGS=$(filter-out -I%,$(REQFLAGS))' >> $@ echo 'OPTFLAGS=$(OPTFLAGS)' >> $@ echo 'LDFLAGS=$(LDFLAGS)' >> $@ - echo "STRIP=$(shell bash -c 'type -p $(STRIP)')" >> $@ + echo "STRIP=$(shell /bin/sh -c 'type $(STRIP)|sed "s,.* ,,"')" >> $@ echo 'STRIPFLAGS=$(STRIPFLAGS)' >> $@ echo 'EMAIN=$(EMAIN)' >> $@ echo 'BITSIZE=$(BITSIZE)' >> $@ @@ -34,7 +34,7 @@ $(CROSS)klcc: klcc.in $(CROSS)klibc.config makeklcc.pl $(PERL) makeklcc.pl klcc.in $(CROSS)klibc.config \ - $(shell bash -c 'type -p $(PERL)') > $@ || ( rm -f $@ ; exit 1 ) + $(shell /bin/sh -c 'type $(PERL)|sed "s,.* ,,"') > $@ || ( rm -f $@ ; exit 1 ) chmod a+x $@ %: local-% # Han -- (_) Consequences, Schmonsequences, as long as I'm rich. -- Looney "==' Tunes, Ali Baba Bunny (1957, Chuck Jones) " " ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel