linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: sysdev_class use from DRM
Date: Thu, 30 Jun 2005 17:40:20 +0000	[thread overview]
Message-ID: <20050630174020.GA11676@kroah.com> (raw)
In-Reply-To: <9e473391050624071263dfbea7@mail.gmail.com>

On Fri, Jun 24, 2005 at 10:12:19AM -0400, Jon Smirl wrote:
> DRM has a model where it runs without attaching to the PCI device. It
> is doing this because the framebuffer devices are already attached to
> the device.
> 
> Some developers want to add power manager support to the DRM drivers.
> Since the normal pm hooks are occupied they are doing this by creating
> a sysdev_class.
> 
> static struct sysdev_class drm_sysdev_class = {
> 	set_kset_name("drm"),
> 	.resume		= drm_resume,
> 	.suspend	= drm_suspend,
> };

Ick, don't do this, this is a hack.

If you really just want to catch the reboot, add a reboot notifier hook
to your driver.

> Don't tell me to merge DRM/fbdev, that fight has been going on for two
> years now.

Well, that's the only real way to fix this.  A simple single driver that
handles the pci registering and doles out the resources and callbacks to
the differnt DRM or fbdev driver is the way to go.  I thought you all
were working on this a year ago...

thanks,

greg k-h


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id\x16492&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  parent reply	other threads:[~2005-06-30 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-24 14:12 sysdev_class use from DRM Jon Smirl
2005-06-24 19:21 ` Jon Smirl
2005-06-24 21:08 ` Dmitry Torokhov
2005-06-30 17:40 ` Greg KH [this message]
2005-06-30 20:55 ` Jon Smirl
2005-07-01 22:23 ` Greg KH
2005-07-01 23:18 ` Jon Smirl
2005-07-02  5:05 ` Greg KH
2005-07-02 13:34 ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050630174020.GA11676@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).