From: Tobias Klauser <tklauser@access.unizh.ch>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] Fix libsyfs include paths
Date: Sun, 31 Jul 2005 21:51:24 +0000 [thread overview]
Message-ID: <20050731215124.GD1155@neon.tklauser.home> (raw)
In-Reply-To: <20050731195620.GC1155@neon.tklauser.home>
On 2005-07-31 at 22:17:46 +0200, Kay Sievers <kay.sievers@vrfy.org> wrote:
> On Sun, Jul 31, 2005 at 09:56:20PM +0200, Tobias Klauser wrote:
> > In the libsysfs/sysfs_*.c files inside the udev distribtiuon the
> > includes for libsysfs.h just state
> >
> > #include "libsysfs.h"
> >
> > while the udev files use
> >
> > #include "libsysfs/sysfs/libsysfs.h"
> >
> > where in fact the header files are. This causes gcc to complain when
> > building udev (and especially the libsysfs part) with -Wall.
>
> This problem only occurs when you overwrite CFLAGS. We moved these
> file multiple times around in the past and every time something
> else broke, just look at the history of these files in the repository.
> I really don't want to start that thing again, for no good reason.
True, sorry about this repeated stupidness. But the includes in the udev
.c files can be deleted, can't they?
Tobias
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id\x16492&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2005-07-31 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-31 19:56 [PATCH] Fix libsyfs include paths Tobias Klauser
2005-07-31 20:17 ` Kay Sievers
2005-07-31 21:51 ` Tobias Klauser [this message]
2005-07-31 22:52 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050731215124.GD1155@neon.tklauser.home \
--to=tklauser@access.unizh.ch \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).