From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Sun, 31 Jul 2005 22:52:00 +0000 Subject: Re: [PATCH] Fix libsyfs include paths Message-Id: <20050731225200.GB1752@vrfy.org> List-Id: References: <20050731195620.GC1155@neon.tklauser.home> In-Reply-To: <20050731195620.GC1155@neon.tklauser.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Sun, Jul 31, 2005 at 11:51:24PM +0200, Tobias Klauser wrote: > On 2005-07-31 at 22:17:46 +0200, Kay Sievers wrote: > > On Sun, Jul 31, 2005 at 09:56:20PM +0200, Tobias Klauser wrote: > > > In the libsysfs/sysfs_*.c files inside the udev distribtiuon the > > > includes for libsysfs.h just state > > > > > > #include "libsysfs.h" > > > > > > while the udev files use > > > > > > #include "libsysfs/sysfs/libsysfs.h" > > > > > > where in fact the header files are. This causes gcc to complain when > > > building udev (and especially the libsysfs part) with -Wall. > > > > This problem only occurs when you overwrite CFLAGS. We moved these > > file multiple times around in the past and every time something > > else broke, just look at the history of these files in the repository. > > I really don't want to start that thing again, for no good reason. > > True, sorry about this repeated stupidness. No, in general the idea is reasonable, but I just don't want to break setups again just for this rather cosmetical reason. > But the includes in the udev > .c files can be deleted, can't they? They could, yes. Today every udev file just includes what it needs itself without assuming on a "global" include. Including and let the Makefile magic decide what happens with that include may be a safe option. Kay ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel