[PATCH] extras/edd_id/edd_id.c: unique signature check

[PATCH] extras/edd_id/edd_id.c: unique signature check

[John_Hull]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

The attached patch adds a check to edd_id.c to verify that the MBR
signature on the device node passed to the program is unique to only
that disk. If the signature is not unique, the program will print an
error to the screen and exit. 

Please review. 

Signed-off-by: John Hull <john_hull@dell.com>



John A. Hull
Linux Solutions Development
Dell Inc.

 

[-- Attachment #2: edd-unique-sig.patch --]
[-- Type: application/octet-stream, Size: 810 bytes --]

--- a/extras/edd_id/edd_id.c.orig	2005-09-08 18:50:01.000000000 -0500
+++ a/extras/edd_id/edd_id.c	2005-09-08 18:37:41.000000000 -0500
@@ -63,6 +63,7 @@
 	int sysfs_fd;
 	DIR *dir = NULL;
 	int rc = 1;
+	char *match = NULL;
 
 	logging_init("edd_id");
 
@@ -165,14 +166,23 @@
 
 		sysfs_id = strtoul(sysfs_id_buf, NULL, 16);
 		if (disk_id == sysfs_id) {
+			if (!match) {
+				match = dent->d_name;
+			} else {
+				info("'%s' does not have a unique signature", node);
+				fprintf(stderr, "'%s' does not have a unique signature\n", node);
+				rc=10;
+				goto exit;
+			}
+		}
+
+	}
+
 			if (export)
-				printf("ID_EDD=%s\n", dent->d_name);
+		printf("ID_EDD=%s\n", match);
 			else
-				printf("%s\n", dent->d_name);
+		printf("%s\n", match);
 			rc = 0;
-			break;
-		}
-	}
 
 close:
 	close(disk_fd);

Re: [PATCH] extras/edd_id/edd_id.c: unique signature check

[Kay Sievers]

On Thu, Sep 08, 2005 at 12:54:10PM -0500, John_Hull@Dell.com wrote:
> The attached patch adds a check to edd_id.c to verify that the MBR
> signature on the device node passed to the program is unique to only
> that disk. If the signature is not unique, the program will print an
> error to the screen and exit. 

Applied!

Thanks,
Kay


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel