From mboxrd@z Thu Jan 1 00:00:00 1970 From: Duncan Sands Date: Fri, 09 Sep 2005 16:41:11 +0000 Subject: Re: [PATCH] firmware_helper.c: correct amount uploaded Message-Id: <200509091841.11966.baldrick@free.fr> List-Id: References: <200509091031.17314.baldrick@free.fr> In-Reply-To: <200509091031.17314.baldrick@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org > > Uploading more than the buffer holds is not a good idea... > > Great, it fixes firmware upload for ipw2200 drivers (in monitor mode). It also fixes firmware upload for speedtch revision 4 modems (problem reported by Andrew Benton, who helped me track it down - thanks Andrew!). In practice the result of this bug was that the amount uploaded was the size of the firmware rounded up to the nearest multiple of the page size (due to the interaction between the bug and the fact that the firmware class only takes one page at a time), though only if the original size was at least one page. So small firmware blobs, or firmware which was a multiple of the page size uploaded OK, which was confusing. > Thanks a lot! No problem, Duncan. ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel