Re: [Pcihpd-discuss] Query regarding interrupt handler code in pciehp

[Greg KH <greg@kroah.com>]

On Thu, Nov 17, 2005 at 02:55:05PM +0900, Rajat Jain wrote:
> Hi,
> 
> This is a query regarding the "interrupt_event_handler()" function in
> pciehp_ctrl.c. Please refer to the following code:
> 
> 673: else if (ctrl->event_queue[loop].event_type = INT_BUTTON_PRESS) {
> 675:    if (ATTN_BUTTN(ctrl->ctrlcap)) {
> 676:            dbg("Button pressed\n");
> 677:            p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
> 678:            if (getstatus) {
> 
> As evident from above, in order to get Power Controller status, it
> checks the capability of Attention Button Present. Shouldn't it check
> the capability of Power Controller Present instead and should be
> written like this:
> 
> if (POWER_CTRL(ctrl->ctrlcap)) {
> 
> Please let me know if I am missing something.

So what exactly would your change look like?  Does the current code not
work properly for you?

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_idv28&alloc_id\x16845&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel