From: Rajesh Shah <rajesh.shah@intel.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [Pcihpd-discuss] Query regarding interrupt handler code in pciehp
Date: Thu, 17 Nov 2005 20:40:45 +0000 [thread overview]
Message-ID: <20051117124044.A3634@unix-os.sc.intel.com> (raw)
In-Reply-To: <20051117060849.GA20218@kroah.com>
On Thu, Nov 17, 2005 at 02:55:05PM +0900, Rajat Jain wrote:
>
> This is a query regarding the "interrupt_event_handler()" function in
> pciehp_ctrl.c. Please refer to the following code:
>
> 673: else if (ctrl->event_queue[loop].event_type = INT_BUTTON_PRESS) {
> 675: if (ATTN_BUTTN(ctrl->ctrlcap)) {
> 676: dbg("Button pressed\n");
> 677: p_slot->hpc_ops->get_power_status(p_slot, &getstatus);
> 678: if (getstatus) {
>
> As evident from above, in order to get Power Controller status, it
> checks the capability of Attention Button Present. Shouldn't it check
> the capability of Power Controller Present instead and should be
This code triggers when pciehp thinks that an attention button
has been pressed. The ATTN_BUTTN() check is just a paranoia check
making sure that the controller reported support for the attention
button for this slot in the slot capabilities register. The
follow on code check if the slot is powered on or not. If it
was powered on, the attention button press was to turn it off
(i.e. hot remove). If it was powered off, the attention button
press was to turn it on (hot add). So, I think the code is
correct.
thanks,
Rajesh
-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
Register for a JBoss Training Course. Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_idv28&alloc_id\x16845&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2005-11-17 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 6:08 [Pcihpd-discuss] Query regarding interrupt handler code in pciehp Greg KH
2005-11-17 20:40 ` Rajesh Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051117124044.A3634@unix-os.sc.intel.com \
--to=rajesh.shah@intel.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).