From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajesh Shah Date: Thu, 17 Nov 2005 20:40:45 +0000 Subject: Re: [Pcihpd-discuss] Query regarding interrupt handler code in pciehp Message-Id: <20051117124044.A3634@unix-os.sc.intel.com> List-Id: References: <20051117060849.GA20218@kroah.com> In-Reply-To: <20051117060849.GA20218@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Thu, Nov 17, 2005 at 02:55:05PM +0900, Rajat Jain wrote: > > This is a query regarding the "interrupt_event_handler()" function in > pciehp_ctrl.c. Please refer to the following code: > > 673: else if (ctrl->event_queue[loop].event_type = INT_BUTTON_PRESS) { > 675: if (ATTN_BUTTN(ctrl->ctrlcap)) { > 676: dbg("Button pressed\n"); > 677: p_slot->hpc_ops->get_power_status(p_slot, &getstatus); > 678: if (getstatus) { > > As evident from above, in order to get Power Controller status, it > checks the capability of Attention Button Present. Shouldn't it check > the capability of Power Controller Present instead and should be This code triggers when pciehp thinks that an attention button has been pressed. The ATTN_BUTTN() check is just a paranoia check making sure that the controller reported support for the attention button for this slot in the slot capabilities register. The follow on code check if the slot is powered on or not. If it was powered on, the attention button press was to turn it off (i.e. hot remove). If it was powered off, the attention button press was to turn it on (hot add). So, I think the code is correct. thanks, Rajesh ------------------------------------------------------- This SF.Net email is sponsored by the JBoss Inc. Get Certified Today Register for a JBoss Training Course. Free Certification Exam for All Training Attendees Through End of 2005. For more info visit: http://ads.osdn.com/?ad_idv28&alloc_id845&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel