From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Borzenkov Date: Wed, 25 Jan 2006 19:57:57 +0000 Subject: Re: udevstart partly broken in 082 Message-Id: <200601252257.58092.arvidjaar@mail.ru> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Wednesday 25 January 2006 21:28, Olivier Blin wrote: > Hi, > > udevstart doesn't run anymore the RUN part of devices that have an > empty NAME. This has been introduced by this 'let "ignore_device" > always return the event successfully' patch: > http://www.kernel.org/git/?p=3Dlinux/hotplug/udev.git;a=3Dcommitdiff_plai= n;h7 >854ffc9ae60da66d5525225c93eb1754a780bb;hp=AD27f5b3962d4cb1e4fcc25d3d0c7d0c= 81 >abc82a This modification in udevstart.c doesn't match the commit message, > was it intended? Also check for ignore_device in loop looks redundant; it is already done a = bit=20 earlier. Does the following sounds OK? - -andrey Subject: [PATCH] Fix udevstart not running RUN callouts for device with emp= ty=20 NAME From: Andrey Borzenkov Signed-off-by: Andrey Borzenkov - --- udevstart.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/udevstart.c b/udevstart.c index 8f8342f..e5ce7af 100644 - --- a/udevstart.c +++ b/udevstart.c @@ -108,7 +108,7 @@ static int add_device(const char *devpat { struct sysfs_device *dev; struct udevice *udev; - - int retval; + int retval =3D 0; =20 /* clear and set environment for next event */ clearenv(); @@ -149,12 +149,10 @@ static int add_device(const char *devpat } if (udev->name[0] !=3D '\0') retval =3D udev_add_device(udev); - - else { + else info("device node creation supressed"); - - goto exit; - - } =20 - - if (retval =3D 0 && !udev->ignore_device && udev_run) { + if (retval =3D 0 && udev_run) { struct name_entry *name_loop; =20 dbg("executing run list"); -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFD19hGR6LMutpd94wRAkcJAJ9+lZ0Jsm7dH3vww6OwDD/bC+GbBACguopn 7O/rdEputPT1B0HieixkSNImAE -----END PGP SIGNATURE----- ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=103432&bid#0486&dat=121642 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel