udevstart partly broken in 082

udevstart partly broken in 082

[Olivier Blin]

Hi,

udevstart doesn't run anymore the RUN part of devices that have an
empty NAME. This has been introduced by this 'let "ignore_device"
always return the event successfully' patch:
http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=commitdiff_plain;h7854ffc9ae60da66d5525225c93eb1754a780bb;hp­27f5b3962d4cb1e4fcc25d3d0c7d0c81abc82a
This modification in udevstart.c doesn't match the commit message, was
it intended?

Regards

-- 
Olivier Blin - Mandriva



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x103432&bid#0486&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udevstart partly broken in 082

[Kay Sievers]

On Wed, Jan 25, 2006 at 07:28:40PM +0100, Olivier Blin wrote:
> udevstart doesn't run anymore the RUN part of devices that have an
> empty NAME. This has been introduced by this 'let "ignore_device"
> always return the event successfully' patch:
> http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=commitdiff_plain;h7854ffc9ae60da66d5525225c93eb1754a780bb;hp­27f5b3962d4cb1e4fcc25d3d0c7d0c81abc82a
> This modification in udevstart.c doesn't match the commit message, was
> it intended?

No, it wasn't intended. I don't use udevstart anymore so I would not have
noticed it too. (I wonder why gcc does not tell me about the uninitialized
variable here.)

I'll go and fix this. I want to reach version 100 soon anyway to get rid of
the leading zero. :)

Thanks,
Kay



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x103432&bid#0486&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udevstart partly broken in 082

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 25 January 2006 21:28, Olivier Blin wrote:
> Hi,
>
> udevstart doesn't run anymore the RUN part of devices that have an
> empty NAME. This has been introduced by this 'let "ignore_device"
> always return the event successfully' patch:
> http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=commitdiff_plain;h7
>854ffc9ae60da66d5525225c93eb1754a780bb;hp­27f5b3962d4cb1e4fcc25d3d0c7d0c81
>abc82a This modification in udevstart.c doesn't match the commit message,
> was it intended?

Also check for ignore_device in loop looks redundant; it is already done a bit 
earlier. Does the following sounds OK?

- -andrey

Subject: [PATCH] Fix udevstart not running RUN callouts for device with empty 
NAME

From: Andrey Borzenkov <arvidjaar@mail.ru>



Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
- ---

 udevstart.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/udevstart.c b/udevstart.c
index 8f8342f..e5ce7af 100644
- --- a/udevstart.c
+++ b/udevstart.c
@@ -108,7 +108,7 @@ static int add_device(const char *devpat
 {
 	struct sysfs_device *dev;
 	struct udevice *udev;
- -	int retval;
+	int retval = 0;
 
 	/* clear and set environment for next event */
 	clearenv();
@@ -149,12 +149,10 @@ static int add_device(const char *devpat
 	}
 	if (udev->name[0] != '\0')
 		retval = udev_add_device(udev);
- -	else {
+	else
 		info("device node creation supressed");
- -		goto exit;
- -	}
 
- -	if (retval = 0 && !udev->ignore_device && udev_run) {
+	if (retval = 0 && udev_run) {
 		struct name_entry *name_loop;
 
 		dbg("executing run list");
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD19hGR6LMutpd94wRAkcJAJ9+lZ0Jsm7dH3vww6OwDD/bC+GbBACguopn
7O/rdEputPT1B0HieixkSNImAE
-----END PGP SIGNATURE-----


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x103432&bid#0486&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udevstart partly broken in 082

[Kay Sievers]

On Wed, Jan 25, 2006 at 10:57:57PM +0300, Andrey Borzenkov wrote:
> On Wednesday 25 January 2006 21:28, Olivier Blin wrote:
> > udevstart doesn't run anymore the RUN part of devices that have an
> > empty NAME. This has been introduced by this 'let "ignore_device"
> > always return the event successfully' patch:
> > http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=commitdiff_plain;h7
> >854ffc9ae60da66d5525225c93eb1754a780bb;hp­27f5b3962d4cb1e4fcc25d3d0c7d0c81
> >abc82a This modification in udevstart.c doesn't match the commit message,
> > was it intended?
> 
> Also check for ignore_device in loop looks redundant; it is already done a bit 
> earlier. Does the following sounds OK?

Sure, looks fine. Applied. Please test it, I'll not notice any breakage. :)

Thanks,
Kay


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x103432&bid#0486&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel