From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Borzenkov Date: Thu, 26 Jan 2006 17:40:54 +0000 Subject: Re: udev_rules_get_run confusion Message-Id: <200601262040.56808.arvidjaar@mail.ru> MIME-Version: 1 Content-Type: multipart/mixed; boundary="nextPart2313795.Mh3rfzKi41" List-Id: References: <200601252342.15059.arvidjaar@mail.ru> In-Reply-To: <200601252342.15059.arvidjaar@mail.ru> To: linux-hotplug@vger.kernel.org --nextPart2313795.Mh3rfzKi41 Content-Type: multipart/mixed; boundary="Boundary-01=_omQ2Dao28HRhNqg" Content-Transfer-Encoding: 7bit Content-Disposition: inline --Boundary-01=_omQ2Dao28HRhNqg Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 26 January 2006 04:57, Kay Sievers wrote: > On Wed, Jan 25, 2006 at 11:42:14PM +0300, Andrey Borzenkov wrote: > > What this function does? As it is now it does *not* get called at all. > Oops I should never post that late. I missed this piece in previous patch.= =20 Trivial one-liner follows. regards =2Dandrey --Boundary-01=_omQ2Dao28HRhNqg Content-Type: text/x-diff; charset="iso-8859-1"; name="remove_apply_from_get_run.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="remove_apply_from_get_run.diff" Subject: [PATCH] Remove udev_rules_apply_format from udev_rules_get_run From: Andrey Borzenkov This removes now redundant substitution (otherwise it will be expanded twice). Signed-off-by: Andrey Borzenkov --- udev_rules.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/udev_rules.c b/udev_rules.c index 90dc024..5d68728 100644 --- a/udev_rules.c +++ b/udev_rules.c @@ -1082,7 +1082,6 @@ int udev_rules_get_run(struct udev_rules name_list_cleanup(&udev->run_list); } strlcpy(program, key_val(rule, &rule->run), sizeof(program)); - udev_rules_apply_format(udev, program, sizeof(program)); dbg("add run '%s'", program); name_list_add(&udev->run_list, program, 0); if (rule->run.operation == KEY_OP_ASSIGN_FINAL) --Boundary-01=_omQ2Dao28HRhNqg-- --nextPart2313795.Mh3rfzKi41 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBD2QmoR6LMutpd94wRAs1JAJ98snPe3qUujCAex4tGsdw+KlNmAQCbBNd3 FNrmMcV+hFIeRBQ7C5FLNvk= =cVSL -----END PGP SIGNATURE----- --nextPart2313795.Mh3rfzKi41-- ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel