From mboxrd@z Thu Jan 1 00:00:00 1970 From: md@Linux.IT (Marco d'Itri) Date: Fri, 27 Jan 2006 16:35:46 +0000 Subject: Re: vol_id and RAID1 members Message-Id: <20060127163546.GA12059@wonderland.linux.it> MIME-Version: 1 Content-Type: multipart/mixed; boundary="wac7ysb48OaltWcw" List-Id: References: <20060124223036.GA16374@wonderland.linux.it> In-Reply-To: <20060124223036.GA16374@wonderland.linux.it> To: linux-hotplug@vger.kernel.org --wac7ysb48OaltWcw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jan 27, Kay Sievers wrote: > > Yes. Indeed, vol_id gets EIO when trying to read the superblock. > >=20 > > I think that in this case it should report the error and exit, because > > as I showed if the partition really is an array member then it will > > report wrong information which if used will cause data loss. >=20 > But how can returning an error by reading the very end of the device > be an indication for a raid device? If we can't find a raid signature, What I meant is that failure to read the partition should be an indication for broken devices. > we should look for a filesystem. I've seen some devices, where the > reported size is not fully readable and they would fail with such a logic, > which would break other things. These devices looks broken or at best misconfigured. In which sane and normal scenario would a partition have sectors which return EIO when read, but be otherwise fully functional? --=20 ciao, Marco --wac7ysb48OaltWcw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQFD2kviFGfw2OHuP7ERAjNRAJ9XtpdWqyZaTCu34lRDxbJDHyzrXACdH9Ku GFZTtVEwjutZvWi/6Pezb00= =HVRA -----END PGP SIGNATURE----- --wac7ysb48OaltWcw-- ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel