Re: Libvolume incorrectly detects FAT32

[Michael Buesch <mbuesch@freenet.de>]

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Monday 06 March 2006 21:57, iSteve wrote:
> Hello,
> I'm having one silly partition, which has remnants of previous FAT32 filesystem
> on it, a LILO bootloader on it and ext2 filesystem spaning all over the
> partition.
> 
> The first 512B look exactly like a valid FAT partition header would, except the
> magic is "LILO". 
> 
> I've looked at the sources for FAT detection, and I noted that when a FAT-like
> filesystem misses magic, it's still considered valid, since as comment says,
> some old floppies may lack it. I consider this point valid, however, this
> causes my partition to be detected, incorrectly, as FAT32.
> 
> My proposed solution is to compare magic if FAT32 is assumed, and if magic will
> not match for FAT32, consider it a failure; floppies that old that they lack
> any magic will most likely not be formatted in FAT32.
> 
> Trivial patch is attached, comments/complaints?:)

Yes, I fear users of stupid digicams may get hit by this.
The Formating option on cheap digicams may sometimes be buggy implemented.
I think you should instead do a
dd if=/dev/zero of=/dev/partition bs=512 count=1
and reformat your partition.

-- 
Greetings Michael.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]