From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: DRIVER vs. PHYSDEVDRIVER for block susbsystem
Date: Sat, 25 Mar 2006 19:43:01 +0000 [thread overview]
Message-ID: <20060325194301.GA23039@vrfy.org> (raw)
In-Reply-To: <200603252125.00463.arvidjaar@mail.ru>
On Sat, Mar 25, 2006 at 10:34:21PM +0300, Andrey Borzenkov wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Saturday 25 March 2006 22:24, Kay Sievers wrote:
>
> > > > No DRIVER matches up the whole chain of devices. But the driver value
> > > > of block is "" which matches successfully the non-match of the values
> > > > it is compared against.
> > > >
> > > > The rules have changed and should work that way:
> > > >
> > > > http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=blob;hb=HEAD;f=et
> > > >c/ud ev/60-persistent-storage.rules
> > >
> > > Those rules will never match for ide-cs or ide-floppy as intended (while
> > > this "fixes" it for ide-cdrom, sure :)
> >
> > Care to explain?
> >
>
> Sure. As you stated before, 'driver value of block is ""'. The "" can never
> match "ide-cd|ide-floppy". And non-block are filtered away two lines before.
No, DRIVER matches up the chain of all devices, it has nothing to do
with the event a non-block device. Did you test it?
> > > > We should not introduce any new users of the "device" link or the
> > > > PHYSDEV* values, they will go away some day along with the odd idea
> > > > to distinguish between class and physical devices.
> [...]
> > > In this case adding driver for block devices looks like the right thing,
> > > does not it? Strictly speaking, it could be generalized to "if device
> > > symlink exists, fetch driver from it"; this will go away when sysfs
> > > layout will have changed.
> >
> > No, the block devices don't have a driver.
> >
>
> Is not this the "odd idea to distinguish between class and physical
> device"? :)
No, it's not. The correct value for the driver of a blockdev is "", as
there is no driver. Copying the value from the parent would be wrong.
Kay
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2006-03-25 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-25 18:24 DRIVER vs. PHYSDEVDRIVER for block susbsystem Andrey Borzenkov
2006-03-25 18:50 ` Kay Sievers
2006-03-25 19:10 ` Andrey Borzenkov
2006-03-25 19:24 ` Kay Sievers
2006-03-25 19:34 ` Andrey Borzenkov
2006-03-25 19:43 ` Kay Sievers [this message]
2006-03-25 20:07 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060325194301.GA23039@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).