From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: udev 085 warnings
Date: Thu, 06 Apr 2006 02:09:31 +0000 [thread overview]
Message-ID: <20060406020931.GA29510@vrfy.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0604051110170.11179@yvahk01.tjqt.qr>
On Thu, Apr 06, 2006 at 02:30:41AM +0200, Michael Buesch wrote:
> On Wednesday 05 April 2006 21:03, Kay Sievers wrote:
> > On Wed, Apr 05, 2006 at 11:10:40AM +0200, Jan Engelhardt wrote:
> > > I am currently compiling udev-085-14.src.rpm from the opensuse
> > > OSS-factory tree on a 64-bit arch and get a lot of these warnings:
> > >
> > > fat.c:325: warning: cast increases required alignment of target type
> > > 325:
> > > next = le32_to_cpu(*((uint32_t *) buf) & 0x0fffffff);
>
> Hm, I don't know what this code is about, but is it actually correct?
> I mean, it masks the value of buf, which is appearently a little-endian
> 32bit value with 0x0fffffff (which is CPU order). Is that intentional?
> Or should it be something like that instead:
> next = le32_to_cpu(*((uint32_t *) buf)) & 0x0fffffff;
I fixed it already while looking for the warning. :)
Thanks,
Kay
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x110944&bid$1720&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2006-04-06 2:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-05 9:10 udev 085 warnings Jan Engelhardt
2006-04-05 19:03 ` Kay Sievers
2006-04-06 0:30 ` Michael Buesch
2006-04-06 2:09 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060406020931.GA29510@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).