From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Thu, 06 Apr 2006 02:09:31 +0000 Subject: Re: udev 085 warnings Message-Id: <20060406020931.GA29510@vrfy.org> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Thu, Apr 06, 2006 at 02:30:41AM +0200, Michael Buesch wrote: > On Wednesday 05 April 2006 21:03, Kay Sievers wrote: > > On Wed, Apr 05, 2006 at 11:10:40AM +0200, Jan Engelhardt wrote: > > > I am currently compiling udev-085-14.src.rpm from the opensuse > > > OSS-factory tree on a 64-bit arch and get a lot of these warnings: > > > > > > fat.c:325: warning: cast increases required alignment of target type > > > 325: > > > next = le32_to_cpu(*((uint32_t *) buf) & 0x0fffffff); > > Hm, I don't know what this code is about, but is it actually correct? > I mean, it masks the value of buf, which is appearently a little-endian > 32bit value with 0x0fffffff (which is CPU order). Is that intentional? > Or should it be something like that instead: > next = le32_to_cpu(*((uint32_t *) buf)) & 0x0fffffff; I fixed it already while looking for the warning. :) Thanks, Kay ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel