From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Buesch Date: Thu, 06 Apr 2006 00:30:41 +0000 Subject: Re: udev 085 warnings Message-Id: <200604060230.42054.mb@bu3sch.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="nextPart1891159.VSszA7xPyd" List-Id: References: In-Reply-To: To: linux-hotplug@vger.kernel.org --nextPart1891159.VSszA7xPyd Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 05 April 2006 21:03, Kay Sievers wrote: > On Wed, Apr 05, 2006 at 11:10:40AM +0200, Jan Engelhardt wrote: > > I am currently compiling udev-085-14.src.rpm from the opensuse > > OSS-factory tree on a 64-bit arch and get a lot of these warnings: > > > > fat.c:325: warning: cast increases required alignment of target type > > 325: > > next =3D le32_to_cpu(*((uint32_t *) buf) & 0x0fffffff); Hm, I don't know what this code is about, but is it actually correct? I mean, it masks the value of buf, which is appearently a little-endian 32bit value with 0x0fffffff (which is CPU order). Is that intentional? Or should it be something like that instead: next =3D le32_to_cpu(*((uint32_t *) buf)) & 0x0fffffff; > > Will there be a proper fix or is this just another of these nice gcc > > warnings that are superfluous? > > GCC is correct warning about that, cause the Makefile asked for that > kind of warning. The buffer access is always aligned but the compiler > can't know that. To get rid of it, you would need to memcpy() the integer > in a variable or access it byte by byte and shift it to an integer > value. Removing -Wcast-align should be the easiest. :) =2D-=20 Greetings Michael. --nextPart1891159.VSszA7xPyd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (GNU/Linux) iD8DBQBENGEylb09HEdWDKgRAuAFAKCvE42JkwZmPLsqP4E6LXpUp0OeMACfbE2t Fuoeddy3ujhE0JHMLOPGem8= =NWSU -----END PGP SIGNATURE----- --nextPart1891159.VSszA7xPyd-- ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel