From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Sun, 03 Sep 2006 03:16:06 +0000 Subject: Re: scripts for persistent names support Message-Id: <20060903031606.GA3399@vrfy.org> List-Id: References: <20060902090653.GA4424@wonderland.linux.it> In-Reply-To: <20060902090653.GA4424@wonderland.linux.it> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Sat, Sep 02, 2006 at 11:06:53AM +0200, Marco d'Itri wrote: > I implemented both the "try again later" and "use a temporary file now" > methods to work around the read-only root problem. > Removing the part of the code you do not need is trivial, and I expect > that everybody will only use the scripts as examples anyway. Very nice. Thanks for doing this. A few comments: > RULES_FILE="/etc/udev/rules.d/z25_persistent-cd.rules" > > . /lib/udev/hotplug.functions Can we name that file udev.functions? > device_description() { > local bus=$(sysreadlink device/bus) > bus=${bus##*/} We should not use the 'device' link. It's only a comment, but it's a nice information. Can't we read this information with udev rules and export it as an environment variable or pass it as an argument. > abort_if_run_early() { > return # DISABLED > # copy the rules generated before / was mounted read-write > for file in /dev/.udev/tmp-rules--*; do > dest=${file##*tmp-rules--} Can't we check with the rule writing script itself, if there are already created temporary rules, and if yes, we just copy them over? That way, the failed-event-replay would just take care of copying for systems who use the --retry-failed? > # ignore interfaces without a driver link > ENV{DRIVER}!="?*", GOTO="persistent_net_generator_end" Does this work? A network device event should never have the DRIVER property set, as it belongs to a parent device. Thanks again, Kay ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel