Re: New software: Hotplug2, aimed at early userspace

[iSteve <isteve@rulez.cz>]

On Mon, 04 Sep 2006 17:09:47 +1000
Aras Vaichas <arasv@magellan-technology.com> wrote:
> I tested 0.4 and it compiles OK with only 1 warning:
> 
> hotplug2.c: In function `main':
> hotplug2.c:244: warning: 'rules' might be used uninitialized in this function
> 
> I can fix by:
> 
> --- hotplug2.c.orig     2006-09-04 17:06:24.000000000 +1000
> +++ hotplug2.c  2006-09-04 17:06:43.000000000 +1000
> @@ -241,7 +241,7 @@
>         int max_child_c = 20;
>         int dumb = 0;
> 
> -       struct rules_t *rules;
> +       struct rules_t *rules = NULL;
>         struct stat statbuf;
>         void *filemap;
>         int rule_fd;
> 

Thanks, applied for not yet released 0.5.

> I'm currently running udev-080 which doesn't have udevtrigger, so I installed
> the udev-098 version of udevtrigger into my system and your hotplug2 seems to
> work OK. My system is a small embedded system so it isn't that much of a speed
> increase because I don't have many devices, but I can at least tell you that
> I've tested it. :)

Great! I have to emphasize that if you're testing, it's important that you kill
the udevd for the time of testing -- otherwise both will try to handle the
given uevents and therefore both will suffer significant slowdown. During the
benchmark, I've attempted to run hotplug2 while having udevd running, hotplug2
scored a little over 10s (ie. approximately 50% slowdown compared to test
without udevd running).

> regards,
> 
> Aras Vaichas
> 
-- 
 -- iSteve

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel