From: md@Linux.IT (md)
To: linux-hotplug@vger.kernel.org
Subject: Re: Some changes in write-cd-rules script
Date: Wed, 01 Nov 2006 14:13:04 +0000 [thread overview]
Message-ID: <20061101141304.GB10763@bongo.bofh.it> (raw)
In-Reply-To: <45410738.9040501@terra.com.br>
On Oct 26, Piter PUNK <piterpk@terra.com.br> wrote:
> I got the following problems:
Your first problem is that you do not understand the locking rules used
by the script.
> +if ! egrep "^ENV{ID_CDROM}=\"\?\*\", ENV{ID_PATH}=\"$ID_PATH\"" /etc/udev/rules.d/* &>/dev/null ; then
> + # Prevent concurrent processes from modifying the file at the same time.
> + lock_rules_file
This creates a race.
Also, checking all files in the directory is broken because some may not
be rules files.
I think that there are other problems, but I have not examined carefully
the script.
--
ciao,
Marco
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2006-11-01 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 19:06 Some changes in write-cd-rules script Piter PUNK
2006-11-01 14:13 ` md [this message]
2006-11-01 15:44 ` Piter PUNK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061101141304.GB10763@bongo.bofh.it \
--to=md@linux.it \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).