From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Wellnitz Date: Wed, 28 Feb 2007 16:07:05 +0000 Subject: Re: dead code in persistent tape rules Message-Id: <20070228160705.GJ14924@ma.emulex.com> List-Id: References: <200702281510.50649.zzam@gentoo.org> In-Reply-To: <200702281510.50649.zzam@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org On Wed, Feb 28, 2007 at 03:10:50PM +0100, Matthias Schwarzott wrote: > Hi there! >=20 > I think last commit to udev (persistent device naming: tape devices and m= edium=20 > changers) contains strange rules that may be thought to look other way. T= his=20 > is how they look now (60-persistent-storage.rules): >=20 > ACTION!=3D"add", GOTO=3D"persistent_storage_end" > ACTION!=3D"add", GOTO=3D"persistent_tape_end" Whoops, that's mine. In an earlier attempt of mine, this block of rules was in a different file and I kept this check. >=20 > Second jump is never reached (as then first already branched to=20 > persistent_storage_end), perhaps that should be SUBSYSTEMS!=3D"scsi" or=20 > similar. As you mention, the 2nd ACTION check could be changed to check for SCSI, something like: SUBSYSTEMS!=3D"scsi", GOTO=3D"persistent_tape_end" or both references to persistent_tape_end could be removed. I don't think I have a preference. >=20 > Matthias >=20 > --=20 > Matthias Schwarzott (zzam) Thanks, Jamie >=20 > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share y= our > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=DE= VDEV > _______________________________________________ > Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net > Linux-hotplug-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel >=20 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=DEVD= EV _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel