From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Wellnitz Date: Wed, 28 Feb 2007 16:42:46 +0000 Subject: Re: dead code in persistent tape rules Message-Id: <20070228164246.GP14924@ma.emulex.com> List-Id: References: <200702281510.50649.zzam@gentoo.org> In-Reply-To: <200702281510.50649.zzam@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org On Wed, Feb 28, 2007 at 05:27:49PM +0100, Kay Sievers wrote: > On 2/28/07, Jamie Wellnitz wrote: > >On Wed, Feb 28, 2007 at 03:10:50PM +0100, Matthias Schwarzott wrote: > >> I think last commit to udev (persistent device naming: tape devices an= d=20 > >medium > >> changers) contains strange rules that may be thought to look other way= .=20 > >This > >> is how they look now (60-persistent-storage.rules): > >> > >> ACTION!=3D"add", GOTO=3D"persistent_storage_end" > >> ACTION!=3D"add", GOTO=3D"persistent_tape_end" > > > >Whoops, that's mine. > > > >In an earlier attempt of mine, this block of rules was in a different > >file and I kept this check. > > > >> Second jump is never reached (as then first already branched to > >> persistent_storage_end), perhaps that should be SUBSYSTEMS!=3D"scsi" or > >> similar. > > > >As you mention, the 2nd ACTION check could be changed to check for > >SCSI, something like: > > > >SUBSYSTEMS!=3D"scsi", GOTO=3D"persistent_tape_end" > > > >or both references to persistent_tape_end could be removed. I don't > >think I have a preference. >=20 > I've removed the jump and the label. Thanks. Sorry about the dead code. >=20 > Thanks, > Kay >=20 Jamie ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=DEVD= EV _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel