From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Guido Diepen <guido@jcwodan.nl>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org,
linux-hotplug-devel@lists.sourceforge.net,
Sergey Vlasov <vsu@altlinux.ru>
Subject: Re: Again problems with PDC20268 and vol_id
Date: Sat, 10 Mar 2007 15:52:09 +0000 [thread overview]
Message-ID: <200703101652.09442.bzolnier@gmail.com> (raw)
In-Reply-To: <200703101057.32631.guido@jcwodan.nl>
[ added Jens to cc: ]
Hi,
On Saturday 10 March 2007, Guido Diepen wrote:
> Hi Sergey,
>
> > Is the partition table correct? Maybe the partition extends beyond
> > the end of physical disk for some reason, and when the kernel tries to
> > access last blocks of the partition, it actually tries to read sectors
> > beyond the actual drive capacity, which fails and exposes broken error
> > handling in the Promise IDE driver.
> >
> > I have added the linux-ide mailing list to Cc: - problems related to
> > IDE/ATA drivers (both old IDE, which you are using currently, and
> > newer libata) should be discussed there.
>
> Last night I copied all data on the /dev/hdg2 partition to other partitions,
> removed the /dev/hdg2 partition and recreated it. Currently everything works
> flawless !!!
Thanks for testing this (and reporting the bug in the first place).
Also big thanks to Sergey for digging out the source of the issue.
> Apparently there is a bug in the promise IDE pdc202xx_new.c driver :)
IDE error recovery code needs improvements (people are working at it)
but there is no wonder that it failed miserably first in DMA mode and later
during PIO retries - it just couldn't read the sector which doesn't exist.
Probably the final steps of error recovery procedure were unsuccessful because
it is using the older method for putting the drive into the "good" idle state
which confuses newer disks (there is a patch - to be merged - from Suleiman
Souhlal addressing this).
However it seems that the root source of the problem was that IDE subsystem
got the request for sector outside the valid sector range and it should _never_
happen for requests originating from the block layer (a lot of code - not only
in the IDE subsystem - assumes this)...
Thanks,
Bart
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CIDÞVDEV
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2007-03-10 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-09 13:16 Again problems with PDC20268 and vol_id Guido Diepen
2007-03-09 13:35 ` Kay Sievers
2007-03-09 16:08 ` Sergey Vlasov
2007-03-09 16:51 ` Guido Diepen
2007-03-09 17:24 ` Sergey Vlasov
2007-03-10 9:57 ` Guido Diepen
2007-03-10 15:52 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703101652.09442.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=axboe@kernel.dk \
--cc=guido@jcwodan.nl \
--cc=linux-hotplug-devel@lists.sourceforge.net \
--cc=linux-ide@vger.kernel.org \
--cc=vsu@altlinux.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).