From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] change Makefile to respect CFLAGS/LDFLAGS
Date: Fri, 27 Apr 2007 11:39:46 +0000 [thread overview]
Message-ID: <200704271339.46462.zzam@gentoo.org> (raw)
In-Reply-To: <200704251038.30238.zzam@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
On Mittwoch, 25. April 2007, Kay Sievers wrote:
> On 4/25/07, Matthias Schwarzott <zzam@gentoo.org> wrote:
> > The attached patch changes the Makefile to not ignore CFLAGS/LDFLAGS from
> > environment.
>
> Applied.
>
> > Was there any strong reason to do so?
>
> No, it's just, that we use OPTFLAGS for that, which is appended by the
> Makefile.
>
Well then, there should be a second change, to not append OPTFLAGS if CFLAGS
was set in environment before.
My patch also sets "-g" only if CFLAGS was unset before.
Matthias
--
Matthias Schwarzott (zzam)
[-- Attachment #2: udev-Makefile-CFLAGS.diff --]
[-- Type: text/x-diff, Size: 740 bytes --]
diff --git a/Makefile b/Makefile
index 072ae7f..7da3baa 100644
--- a/Makefile
+++ b/Makefile
@@ -113,7 +113,10 @@ LD = $(CROSS_COMPILE)gcc
AR = $(CROSS_COMPILE)ar
RANLIB = $(CROSS_COMPILE)ranlib
-CFLAGS += -g -Wall -pipe -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
+OPTFLAGS = -Os
+CFLAGS ?= $(OPTFLAGS) -g
+
+CFLAGS += -Wall -pipe -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
WARNINGS = -Wstrict-prototypes -Wsign-compare -Wshadow \
-Wchar-subscripts -Wmissing-declarations -Wnested-externs \
-Wpointer-arith -Wcast-align -Wsign-compare -Wmissing-prototypes
@@ -121,9 +124,6 @@ CFLAGS += $(WARNINGS)
LDFLAGS += -Wl,-warn-common
-OPTFLAGS = -Os
-CFLAGS += $(OPTFLAGS)
-
ifeq ($(strip $(USE_LOG)),true)
CFLAGS += -DUSE_LOG
endif
[-- Attachment #3: Type: text/plain, Size: 286 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
[-- Attachment #4: Type: text/plain, Size: 226 bytes --]
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2007-04-27 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 8:38 [PATCH] change Makefile to respect CFLAGS/LDFLAGS Matthias Schwarzott
2007-04-25 21:34 ` Kay Sievers
2007-04-27 11:39 ` Matthias Schwarzott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704271339.46462.zzam@gentoo.org \
--to=zzam@gentoo.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).