Couple more sample rules typos

Couple more sample rules typos

[Bryan Kadzban]

[-- Attachment #1: Type: text/plain, Size: 1650 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

There are two more missing commas in the sample rules files: in the
auer[0-9]* rule, and in the SUBSYSTEMS=="bsg" rule.  The attached patch
(generated against the current git tree) adds them.

These are the only two instances of missing commas in the current files,
according to the following test:

grep --color '="[^"]*"[^,]' etc/udev/rules.d/*.rules

which tests for an equals sign, then any value between a single set of
double quotes, then any character other than a comma.  It then prints
out the matching string in red by default (depends on $GREP_COLOR).

(That test will trigger a false positive if the value between double
quotes uses any escaped double quotes itself.  No current rules do that
though, so for the moment, it's OK.)

That test also triggered on a trailing space in the DVB rule.  The space
doesn't seem to affect anything, but since removing it won't affect
anything either, and it's a false positive on the test above, I think it
should be removed.  I've done that in this patch as well.

(Would it be easy to add an automated test for this to the package, or
to the git repo?  Commas have been removed or forgotten a few times now;
it seems like a good idea to have some kind of automatic test for that
to me, if it's not too hard to set up.  I'd suspect the grep above would
be a decent starting place for the test.)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHESsaS5vET1Wea5wRA56ZAKCaR4LjF3Yal/KPHLShRsBAewO4xgCgo42p
VEOFvo4F3V9I/fx/R0GXQZY=
=NejA
-----END PGP SIGNATURE-----

[-- Attachment #2: udev-current-git-fix-typos.patch --]
[-- Type: text/plain, Size: 1220 bytes --]

diff -ur a/etc/udev/rules.d/50-udev-default.rules b/etc/udev/rules.d/50-udev-default.rules
--- a/etc/udev/rules.d/50-udev-default.rules	2007-10-13 16:09:50.000000000 -0400
+++ b/etc/udev/rules.d/50-udev-default.rules	2007-10-13 16:10:41.000000000 -0400
@@ -39,7 +39,7 @@
 KERNEL=="fb0",			SYMLINK+="fb"
 
 # DVB video
-SUBSYSTEM=="dvb", PROGRAM="/bin/sh -c 'K=%k; K=$${K#dvb}; printf dvb/adapter%%i/%%s $${K%%%%.*} $${K#*.}'", NAME="%c" 
+SUBSYSTEM=="dvb", PROGRAM="/bin/sh -c 'K=%k; K=$${K#dvb}; printf dvb/adapter%%i/%%s $${K%%%%.*} $${K#*.}'", NAME="%c"
 
 # Firewire
 KERNEL=="dv1394*",		SYMLINK+="dv1394/%n"
@@ -77,7 +77,7 @@
 KERNEL=="pktcdvd[0-9]*",	NAME="pktcdvd/%k"
 KERNEL=="pktcdvd",		NAME="pktcdvd/control"
 KERNEL=="qft0",			SYMLINK+="ftape"
-SUBSYSTEM=="bsg"		NAME="bsg/%k"
+SUBSYSTEM=="bsg",		NAME="bsg/%k"
 
 # network
 KERNEL=="tun",			NAME="net/%k", MODE="0666", OPTIONS+="ignore_remove"
@@ -91,7 +91,7 @@
 KERNEL=="fuse",			MODE="0666"
 KERNEL=="rtc|rtc0",		MODE="0644"
 KERNEL=="rtc0",			SYMLINK+="rtc"
-KERNEL=="auer[0-9]*"		NAME="usb/%k"
+KERNEL=="auer[0-9]*",		NAME="usb/%k"
 KERNEL=="hw_random",		NAME="hwrng", SYMLINK+="%k"
 KERNEL=="mmtimer",		MODE="0644"
 KERNEL=="rflash[0-9]*",		MODE="0400"

[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 226 bytes --]

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: Couple more sample rules typos

[Kay Sievers]

On 10/13/07, Bryan Kadzban <bryan@kadzban.is-a-geek.net> wrote:
> There are two more missing commas in the sample rules files: in the
> auer[0-9]* rule, and in the SUBSYSTEMS="bsg" rule.  The attached patch
> (generated against the current git tree) adds them.
>
> These are the only two instances of missing commas in the current files,
> according to the following test:
>
> grep --color '="[^"]*"[^,]' etc/udev/rules.d/*.rules
>
> which tests for an equals sign, then any value between a single set of
> double quotes, then any character other than a comma.  It then prints
> out the matching string in red by default (depends on $GREP_COLOR).
>
> (That test will trigger a false positive if the value between double
> quotes uses any escaped double quotes itself.  No current rules do that
> though, so for the moment, it's OK.)
>
> That test also triggered on a trailing space in the DVB rule.  The space
> doesn't seem to affect anything, but since removing it won't affect
> anything either, and it's a false positive on the test above, I think it
> should be removed.  I've done that in this patch as well.
>
> (Would it be easy to add an automated test for this to the package, or
> to the git repo?  Commas have been removed or forgotten a few times now;
> it seems like a good idea to have some kind of automatic test for that
> to me, if it's not too hard to set up.  I'd suspect the grep above would
> be a decent starting place for the test.)

Applied. It's in version 116.

Thanks,
Kay

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: Couple more sample rules typos

[Matthias Schwarzott]

On Samstag, 13. Oktober 2007, Bryan Kadzban wrote:
> There are two more missing commas in the sample rules files: in the
> auer[0-9]* rule, and in the SUBSYSTEMS="bsg" rule.  The attached patch
> (generated against the current git tree) adds them.
>
> These are the only two instances of missing commas in the current files,
> according to the following test:
>
> grep --color '="[^"]*"[^,]' etc/udev/rules.d/*.rules
>

It seems there are more affected files around:
etc/udev/suse/40-suse.rules:SUBSYSTEM="graphics"               GROUP="video"
etc/udev/debian/permissions.rules:
KERNEL="event[0-9]*", ATTRS{name}="*dvb*|*DVB*|* IR *" \
                                MODE="0664",    GROUP="video"

87 lines from etc/udev/frugalware/50-udev-default.rules

one false positive:
etc/udev/debian/run.rules:KERNEL="tty" ,       OPTIONS+="last_rule"

Matthias

-- 
Matthias Schwarzott (zzam)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: Couple more sample rules typos

[Bryan Kadzban]

[-- Attachment #1.1: Type: text/plain, Size: 633 bytes --]

On Mon, Oct 15, 2007 at 03:10:09PM +0200, Matthias Schwarzott wrote:
> It seems there are more affected files around:

Yeah, I didn't look at the distro-specific rules.  I figured only the
ones that got installed by udev mattered (anyone using one of these
distros would install that distro's udev package, which should come with
their "real" rules).

Although I also didn't look at the various rules files under extras/
initially, I just did check through -116, and none of the extras/ rules
are matching the regex.

If we want to fix these, I think it'd be a lower priority than the
sample rules (or anything else udev installs).


[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 226 bytes --]

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: Couple more sample rules typos

[VMiklos]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

2007/10/15, Matthias Schwarzott <zzam@gentoo.org>:
> 87 lines from etc/udev/frugalware/50-udev-default.rules

ah, thanks for the heads up. Kay, could you please apply the attached
patch? i hope i corrected all of them (in fact i corrected only 86 :)
)

thanks,
- VMiklos

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-missing-commas-in-the-Frugalware-rules-file.patch --]
[-- Type: text/x-patch; name="0001-Add-missing-commas-in-the-Frugalware-rules-file.patch", Size: 16711 bytes --]

From 966ab572f3774aff7a9ce9655b1c16314b1e04fe Mon Sep 17 00:00:00 2001
From: Miklos Vajna <vmiklos@frugalware.org>
Date: Mon, 15 Oct 2007 21:39:33 +0200
Subject: [PATCH] Add missing commas in the Frugalware rules file

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
 etc/udev/frugalware/50-udev-default.rules |  172 ++++++++++++++--------------
 1 files changed, 86 insertions(+), 86 deletions(-)

diff --git a/etc/udev/frugalware/50-udev-default.rules b/etc/udev/frugalware/50-udev-default.rules
index 2f47773..89ffd7b 100644
--- a/etc/udev/frugalware/50-udev-default.rules
+++ b/etc/udev/frugalware/50-udev-default.rules
@@ -27,10 +27,10 @@ KERNEL=="tun",		NAME="net/%k"
 # permissions
 KERNEL=="pl2303",        NAME="%k", OWNER="500",  GROUP="500",  MODE="0666"
 KERNEL=="visor",         NAME="%k", OWNER="root", GROUP="uucp", MODE="0666"
-KERNEL=="camera*"        NAME="%k", OWNER="root",  GROUP="camera",  MODE="0666"
+KERNEL=="camera*",        NAME="%k", OWNER="root",  GROUP="camera",  MODE="0666"
 
 # console devices
-KERNEL=="console"        NAME="%k", OWNER="root", GROUP="tty",  MODE="0600"
+KERNEL=="console",        NAME="%k", OWNER="root", GROUP="tty",  MODE="0600"
 KERNEL=="tty",           NAME="%k", OWNER="root", GROUP="tty",  MODE="0666"
 KERNEL=="tty[0-9]*",     NAME="%k", OWNER="root", GROUP="tty",  MODE="0660"
 KERNEL=="vcs*",          NAME="%k", OWNER="root", GROUP="tty",  MODE="0620"
@@ -40,33 +40,33 @@ KERNEL=="ttyUSB0",       NAME="%k", OWNER="root", GROUP="uucp", MODE="0660"
 KERNEL=="ttyUSB1",       NAME="%k", OWNER="root"  GROUP="uucp", MODE="0666"
 
 # pty devices
-KERNEL=="ptmx"           NAME="%k", OWNER="root", GROUP="tty",  MODE="0666"
-KERNEL=="pty[p-za-e][0-9a-f]*" NAME="%k", OWNER="root", GROUP="tty",  MODE="0666"
-KERNEL=="tty[p-za-e][0-9a-f]*" NAME="%k", OWNER="root", GROUP="tty",  MODE="0666"
-KERNEL=="cu[abiu]*"      NAME="%k", OWNER="root", GROUP="uucp",  MODE="0660"
+KERNEL=="ptmx",           NAME="%k", OWNER="root", GROUP="tty",  MODE="0666"
+KERNEL=="pty[p-za-e][0-9a-f]*", NAME="%k", OWNER="root", GROUP="tty",  MODE="0666"
+KERNEL=="tty[p-za-e][0-9a-f]*", NAME="%k", OWNER="root", GROUP="tty",  MODE="0666"
+KERNEL=="cu[abiu]*",      NAME="%k", OWNER="root", GROUP="uucp",  MODE="0660"
 
 # sound devices
-KERNEL=="audio*"         NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="beep"           NAME="%k", OWNER="root", GROUP="audio", MODE="0644"
-KERNEL=="dsp*"           NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="midi*"          NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="mixer*"         NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="music"          NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="sequencer*"     NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="audio*",         NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="beep",           NAME="%k", OWNER="root", GROUP="audio", MODE="0644"
+KERNEL=="dsp*",           NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="midi*",          NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="mixer*",         NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="music",          NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="sequencer*",     NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
 KERNEL=="controlC[0-9]*", NAME="snd/%k", OWNER="root", GROUP="audio",  MODE="0666"
 KERNEL=="hw[CD0-9]*",     NAME="snd/%k", OWNER="root", GROUP="audio",  MODE="0666"
 KERNEL=="pcm[CD0-9cp]*",  NAME="snd/%k", OWNER="root", GROUP="audio",  MODE="0666"
 KERNEL=="midiC[D0-9]*",   NAME="snd/%k", OWNER="root", GROUP="audio",  MODE="0666"
 KERNEL=="timer",          NAME="snd/%k", OWNER="root", GROUP="audio",  MODE="0666"
 KERNEL=="seq",            NAME="snd/%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="sndstat"        NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="speaker"        NAME="%k", OWNER="root", GROUP="audio", MODE="0644"
-KERNEL=="sound/*"        NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
-KERNEL=="admmidi*"       NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
-KERNEL=="adsp*"          NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
-KERNEL=="aload*"         NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
-KERNEL=="amidi*"         NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
-KERNEL=="amixer*"        NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
+KERNEL=="sndstat",        NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="speaker",        NAME="%k", OWNER="root", GROUP="audio", MODE="0644"
+KERNEL=="sound/*",        NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
+KERNEL=="admmidi*",       NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
+KERNEL=="adsp*",          NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
+KERNEL=="aload*",         NAME="%k", OWNER="root", GROUP="audio",  MODE="0666"
+KERNEL=="amidi*",         NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
+KERNEL=="amixer*",        NAME="%k", OWNER="root", GROUP="audio", MODE="0666"
 
 # input devices (mouse, joystick, etc)
 KERNEL=="mice",		NAME="input/%k", OWNER="root", GROUP="root", MODE="0644"
@@ -74,46 +74,46 @@ KERNEL=="mouse*",	NAME="input/%k", OWNER="root", GROUP="root", MODE="0644"
 KERNEL=="event*",	NAME="input/%k", OWNER="root", GROUP="root", MODE="0644"
 KERNEL=="js*",		NAME="input/%k", OWNER="root", GROUP="root", MODE="0644"
 KERNEL=="ts*",		NAME="input/%k", OWNER="root", GROUP="root", MODE="0644"
-KERNEL=="input/js*"      NAME="%k", OWNER="root", GROUP="games",0 MODE="0666"
-KERNEL=="djs[0-3]"       NAME="%k", OWNER="root", GROUP="games", MODE="0660"
-KERNEL=="psaux"          NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
-KERNEL=="crash"          NAME="%k", OWNER="root", GROUP="root", MODE="0660"
-KERNEL=="logibm"         NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
-KERNEL=="jbm"            NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
-KERNEL=="hwtrap"         NAME="%k", OWNER="root", GROUP="root", MODE="0644"
-KERNEL=="inportbm"       NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
-KERNEL=="sexec"          NAME="%k", OWNER="root", GROUP="root", MODE="0660"
-KERNEL=="jsflash"        NAME="%k", OWNER="root", GROUP="root", MODE="0660"
+KERNEL=="input/js*",      NAME="%k", OWNER="root", GROUP="games",0 MODE="0666"
+KERNEL=="djs[0-3]",       NAME="%k", OWNER="root", GROUP="games", MODE="0660"
+KERNEL=="psaux",          NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
+KERNEL=="crash",          NAME="%k", OWNER="root", GROUP="root", MODE="0660"
+KERNEL=="logibm",         NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
+KERNEL=="jbm",            NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
+KERNEL=="hwtrap",         NAME="%k", OWNER="root", GROUP="root", MODE="0644"
+KERNEL=="inportbm",       NAME="%k", OWNER="root", GROUP="sys",  MODE="0660"
+KERNEL=="sexec",          NAME="%k", OWNER="root", GROUP="root", MODE="0660"
+KERNEL=="jsflash",        NAME="%k", OWNER="root", GROUP="root", MODE="0660"
 
 # power manager device
-KERNEL=="apm_bios"        NAME="%k", OWNER="root", GROUP="root", MODE="0644"
+KERNEL=="apm_bios",        NAME="%k", OWNER="root", GROUP="root", MODE="0644"
 
 # printer device
-KERNEL=="lp[0-9]"         NAME="%k", OWNER="root", GROUP="lp", MODE="0660"
-KERNEL=="parport*"        NAME="%k", OWNER="root", GROUP="lp", MODE="0660"
+KERNEL=="lp[0-9]",         NAME="%k", OWNER="root", GROUP="lp", MODE="0660"
+KERNEL=="parport*",        NAME="%k", OWNER="root", GROUP="lp", MODE="0660"
 
 # video devices
-KERNEL=="card*"        NAME="dri/card%n", OWNER="root", GROUP="video", MODE="0666"
-KERNEL=="fb[0-9]"         NAME="%k", OWNER="root", GROUP="video",  MODE="0660"
-KERNEL=="agpgart"         NAME="%k", OWNER="root", GROUP="video", MODE="0660"
-KERNEL=="nvidia*"         NAME="%k", OWNER="root", GROUP="video", MODE="0666"
-KERNEL=="video*"          NAME="%k", OWNER="root", GROUP="video",  MODE="0660"
-KERNEL=="vbi*"            NAME="%k", OWNER="root", GROUP="video", MODE="0660"
+KERNEL=="card*",        NAME="dri/card%n", OWNER="root", GROUP="video", MODE="0666"
+KERNEL=="fb[0-9]",         NAME="%k", OWNER="root", GROUP="video",  MODE="0660"
+KERNEL=="agpgart",         NAME="%k", OWNER="root", GROUP="video", MODE="0660"
+KERNEL=="nvidia*",         NAME="%k", OWNER="root", GROUP="video", MODE="0666"
+KERNEL=="video*",          NAME="%k", OWNER="root", GROUP="video",  MODE="0660"
+KERNEL=="vbi*",            NAME="%k", OWNER="root", GROUP="video", MODE="0660"
 KERNEL=="dvb*",	PROGRAM="/bin/sh -c 'K=%k; K=$${K#dvb}; A=$${K%%%%.*}; D=$${K#*.}; echo dvb/adapter$$A/$$D'", NAME="%c", GROUP="video", MODE="0660"
 
 # DISK devices
-KERNEL=="ed[ab]*"         NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
-KERNEL=="gscd0"           NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
-KERNEL=="initrd"          NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
-KERNEL=="lmscd"           NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
-KERNEL=="mcd*"            NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
-KERNEL=="md*"             NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
-KERNEL=="mtd*"            NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
-KERNEL=="userdma"         NAME="%k", OWNER="root", GROUP="root", MODE="0660"
+KERNEL=="ed[ab]*",         NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
+KERNEL=="gscd0",           NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
+KERNEL=="initrd",          NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
+KERNEL=="lmscd",           NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
+KERNEL=="mcd*",            NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
+KERNEL=="md*",             NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
+KERNEL=="mtd*",            NAME="%k", OWNER="root", GROUP="disk", MODE="0640"
+KERNEL=="userdma",         NAME="%k", OWNER="root", GROUP="root", MODE="0660"
 
 # floppy devices
-KERNEL=="fd[0-3]*"        NAME="%k", OWNER="root", GROUP="floppy", MODE="0660"
-KERNEL=="fd0"             SYMLINK="floppy"
+KERNEL=="fd[0-3]*",        NAME="%k", OWNER="root", GROUP="floppy", MODE="0660"
+KERNEL=="fd0",             SYMLINK="floppy"
 
 # permissions for removable devices like cardreaders or sticks
 KERNEL=="sd*", ATTRS{scsi_level}=="3", ATTRS{type}=="0", NAME="%k", GROUP="storage"
@@ -125,60 +125,60 @@ KERNEL=="sd*", ATTRS{scsi_level}=="5", NAME="%k", GROUP="storage"
 KERNEL=="sd*", ATTRS{scsi_level}=="3", ATTRS{type}=="7", NAME="%k", GROUP="storage"
 
 # IDE devices (hd, cdrom)
-KERNEL=="hd*"             NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
-KERNEL=="ht0"             NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
+KERNEL=="hd*",             NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="ht0",             NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
 
 # RAID IDE
-KERNEL=="ataraid[0-9]*"   NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
-KERNEL=="ataraid/*"       NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="ataraid[0-9]*",   NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="ataraid/*",       NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
 
 # SCSI devices
-KERNEL=="scsi/*/cd"       NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
-KERNEL=="scsi/*"          NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
-KERNEL=="sd[a-h]*"        NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
-KERNEL=="s[rt][0-9]*"     NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
-KERNEL=="scd*"            NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="scsi/*/cd",       NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="scsi/*",          NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="sd[a-h]*",        NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
+KERNEL=="s[rt][0-9]*",     NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
+KERNEL=="scd*",            NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
 
 # generic scsi devices
-KERNEL=="sg*"             NAME="%k", OWNER="root", GROUP="root",   MODE="0600"
+KERNEL=="sg*",             NAME="%k", OWNER="root", GROUP="root",   MODE="0600"
 
 # old CD-ROM
-KERNEL=="sbpcd*"          NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
+KERNEL=="sbpcd*",          NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
 
 # loop devices
-KERNEL=="loop[0-9]*"      NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="loop[0-9]*",      NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
 
 # network block devices
-KERNEL=="nb[0-7]"         NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
-KERNEL=="nht0"            NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
-KERNEL=="npt[0-3]"        NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
-KERNEL=="n[qrs]*"         NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
+KERNEL=="nb[0-7]",         NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="nht0",            NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
+KERNEL=="npt[0-3]",        NAME="%k", OWNER="root", GROUP="disk",   MODE="0660"
+KERNEL=="n[qrs]*",         NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
 
 # memory access devices
-KERNEL=="kmem"         NAME="%k", OWNER="root", GROUP="kmem",   MODE="0640"
-KERNEL=="mem"          NAME="%k", OWNER="root", GROUP="kmem",   MODE="0640"
-KERNEL=="null"         NAME="%k", OWNER="root", GROUP="sys",    MODE="0666"
-KERNEL=="nvram"        NAME="%k", OWNER="root", GROUP="root",   MODE="0640"
-KERNEL=="port"         NAME="%k", OWNER="root", GROUP="kmem",   MODE="0640"
-KERNEL=="ram[0-9]*"    NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
-KERNEL=="random"       NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
-KERNEL=="rtc"          NAME="%k", OWNER="root", GROUP="root",   MODE="0444"
-KERNEL=="urandom"      NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
-KERNEL=="full"         NAME="%k", OWNER="root", GROUP="sys",    MODE="0666"
-KERNEL=="zero"         NAME="%k", OWNER="root", GROUP="root",   MODE="0666"
-KERNEL=="raw[0-9]*"    NAME="raw/%k", OWNER="root", GROUP="disk", MODE="0660"
-KERNEL=="modreq"       NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
-KERNEL=="msr"          NAME="%k", OWNER="root", GROUP="root",   MODE="0660"
-KERNEL=="profile*"     NAME="%k", OWNER="root", GROUP="root",   MODE="0640"
+KERNEL=="kmem",         NAME="%k", OWNER="root", GROUP="kmem",   MODE="0640"
+KERNEL=="mem",          NAME="%k", OWNER="root", GROUP="kmem",   MODE="0640"
+KERNEL=="null",         NAME="%k", OWNER="root", GROUP="sys",    MODE="0666"
+KERNEL=="nvram",        NAME="%k", OWNER="root", GROUP="root",   MODE="0640"
+KERNEL=="port",         NAME="%k", OWNER="root", GROUP="kmem",   MODE="0640"
+KERNEL=="ram[0-9]*",    NAME="%k", OWNER="root", GROUP="disk",   MODE="0640"
+KERNEL=="random",       NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
+KERNEL=="rtc",          NAME="%k", OWNER="root", GROUP="root",   MODE="0444"
+KERNEL=="urandom",      NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
+KERNEL=="full",         NAME="%k", OWNER="root", GROUP="sys",    MODE="0666"
+KERNEL=="zero",         NAME="%k", OWNER="root", GROUP="root",   MODE="0666"
+KERNEL=="raw[0-9]*",    NAME="raw/%k", OWNER="root", GROUP="disk", MODE="0660"
+KERNEL=="modreq",       NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
+KERNEL=="msr",          NAME="%k", OWNER="root", GROUP="root",   MODE="0660"
+KERNEL=="profile*",     NAME="%k", OWNER="root", GROUP="root",   MODE="0640"
 
 # ISDN devices
-KERNEL=="isdn*"        NAME="%k", OWNER="root", GROUP="tty",    MODE="0660"
+KERNEL=="isdn*",        NAME="%k", OWNER="root", GROUP="tty",    MODE="0660"
 
 # net devices
-KERNEL=="ippp*"        NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
-KERNEL=="ipstate*"     NAME="%k", OWNER="root", GROUP="root",   MODE="0660"
-KERNEL=="spx"          NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
-KERNEL=="fwmonitor*"   NAME="%k", OWNER="root", GROUP="root",   MODE="0660"
+KERNEL=="ippp*",        NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
+KERNEL=="ipstate*",     NAME="%k", OWNER="root", GROUP="root",   MODE="0660"
+KERNEL=="spx",          NAME="%k", OWNER="root", GROUP="root",   MODE="0644"
+KERNEL=="fwmonitor*",   NAME="%k", OWNER="root", GROUP="root",   MODE="0660"
 
 # hotplug rules - module autoloading for different buses
 ACTION=="add", SUBSYSTEM=="pci", ENV{MODALIAS}=="*", RUN+="/sbin/modprobe $env{MODALIAS}"
-- 
1.5.3.4


[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 226 bytes --]

_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: Couple more sample rules typos

[Kay Sievers]

On 10/15/07, VMiklos <vmiklos@gmail.com> wrote:
> 2007/10/15, Matthias Schwarzott <zzam@gentoo.org>:
> > 87 lines from etc/udev/frugalware/50-udev-default.rules
>
> ah, thanks for the heads up. Kay, could you please apply the attached
> patch? i hope i corrected all of them (in fact i corrected only 86 :)

Applied.

Thanks,
Kay

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel