From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 09 Nov 2007 21:32:23 +0000 Subject: Re: [PATCH] create /sys/.../power when CONFIG_PM is set Message-Id: <20071109213223.GA28276@kroah.com> List-Id: References: <20071107101043.2E64C9D4ECC@zog.reactivated.net> <20071109130555.5304d49a.akpm@linux-foundation.org> In-Reply-To: <20071109130555.5304d49a.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Daniel Drake , rjw@sisk.pl, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, kay.sievers@vrfy.org, linux-hotplug-devel@lists.sourceforge.net, oneukum@suse.de On Fri, Nov 09, 2007 at 01:05:55PM -0800, Andrew Morton wrote: > On Wed, 7 Nov 2007 10:10:43 +0000 (GMT) > Daniel Drake wrote: > > > The CONFIG_SUSPEND changes in 2.6.23 caused a regression under certain > > configuration conditions (SUSPEND=n, USB_AUTOSUSPEND=y) where all USB device > > attributes in sysfs (idVendor, idProduct, ...) silently disappeared, causing > > udev breakage and more. > > > > The cause of this is that the /sys/.../power subdirectory is now only created > > when CONFIG_PM_SLEEP is set, however, it should be created whenever CONFIG_PM > > is set to handle the above situation. The following patch fixes the > > regression. > > > > Your patch is for 2.6.24-rc2 and 2.6.23, afacit. It needed some work to > apply on Greg's tree because the new pm_sleep_lock() and pm_sleep_unlock() > went and copied the same bug as you've fixed here. > > I guess the right thing to do is to apply your patch as-is to 2.6.24-rcX > and to 2.6.23.x. I can't really do that because doing so would wreck my > copy of Greg's tree. > > > So I'll run with the below (I think it's right) and will let Greg sort it > out ;) Yeah, I'll sort it all out :) thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel