strange version jump of libvolume_id.so with udev-126

strange version jump of libvolume_id.so with udev-126

[Matthias Schwarzott]

Hi there!

It seems the version of libvolume_id.so jumped in an unwanted way between 
udev-125 and udev-126.

udev-125 installed this lib:
/lib/libvolume_id.so.0.85.0

But udev-126 does install this:
/lib/libvolume_id.so.0.0.86


One more libtool strangeness I guess.
extras/volume_id/lib/Makefile uses
-version-info $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)

changing that to
-version-number $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)

creates versions as usual:
/lib/libvolume_id.so.0.86.0

Regards
Matthias

Re: strange version jump of libvolume_id.so with udev-126

[Kay Sievers]

On Thu, Aug 28, 2008 at 11:04, Matthias Schwarzott <zzam@gentoo.org> wrote:
> It seems the version of libvolume_id.so jumped in an unwanted way between
> udev-125 and udev-126.
>
> udev-125 installed this lib:
> /lib/libvolume_id.so.0.85.0
>
> But udev-126 does install this:
> /lib/libvolume_id.so.0.0.86
>
>
> One more libtool strangeness I guess.
> extras/volume_id/lib/Makefile uses
> -version-info $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)
>
> changing that to
> -version-number $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)

Yeah, but that it looks right. The old numbers have been wrong. We
intended to increase the revision, not the age. That's what you get
with home-grown Makefiles, it's just wrong in too many cases. :)

I guess, it's time to remove the deprecated functions from
libvolume_id now, and bump the major to 1, if the new (and correct)
naming is causing trouble?

Thanks,
Kay

Re: strange version jump of libvolume_id.so with udev-126

[Dan Nicholson]

On Thu, Aug 28, 2008 at 5:21 AM, Kay Sievers <kay.sievers@vrfy.org> wrote:
> On Thu, Aug 28, 2008 at 11:04, Matthias Schwarzott <zzam@gentoo.org> wrote:
>> It seems the version of libvolume_id.so jumped in an unwanted way between
>> udev-125 and udev-126.
>>
>> udev-125 installed this lib:
>> /lib/libvolume_id.so.0.85.0
>>
>> But udev-126 does install this:
>> /lib/libvolume_id.so.0.0.86
>>
>>
>> One more libtool strangeness I guess.
>> extras/volume_id/lib/Makefile uses
>> -version-info $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)
>>
>> changing that to
>> -version-number $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)
>
> Yeah, but that it looks right. The old numbers have been wrong. We
> intended to increase the revision, not the age. That's what you get
> with home-grown Makefiles, it's just wrong in too many cases. :)
>
> I guess, it's time to remove the deprecated functions from
> libvolume_id now, and bump the major to 1, if the new (and correct)
> naming is causing trouble?

You could keep using -version-info and pass 85:1:85 or 86:0:86. That
would give you .so.0.85.1 or .so.0.86.0. That would keep the status
quo for now and you could just follow the libtool rules from there:

http://www.gnu.org/software/libtool/manual/libtool.html#Updating-version-info

Once you decide to bump to .so.1, you could reset to 1:0:0 or
something more in line with the "number of interfaces" concept in
libtool.

--
Dan

Re: strange version jump of libvolume_id.so with udev-126

[Kay Sievers]

On Thu, 2008-08-28 at 08:38 -0700, Dan Nicholson wrote:
> On Thu, Aug 28, 2008 at 5:21 AM, Kay Sievers <kay.sievers@vrfy.org> wrote:
> > On Thu, Aug 28, 2008 at 11:04, Matthias Schwarzott <zzam@gentoo.org> wrote:
> >> It seems the version of libvolume_id.so jumped in an unwanted way between
> >> udev-125 and udev-126.
> >>
> >> udev-125 installed this lib:
> >> /lib/libvolume_id.so.0.85.0
> >>
> >> But udev-126 does install this:
> >> /lib/libvolume_id.so.0.0.86
> >>
> >>
> >> One more libtool strangeness I guess.
> >> extras/volume_id/lib/Makefile uses
> >> -version-info $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)
> >>
> >> changing that to
> >> -version-number $(VOLID_LT_CURRENT):$(VOLID_LT_REVISION):$(VOLID_LT_AGE)
> >
> > Yeah, but that it looks right. The old numbers have been wrong. We
> > intended to increase the revision, not the age. That's what you get
> > with home-grown Makefiles, it's just wrong in too many cases. :)
> >
> > I guess, it's time to remove the deprecated functions from
> > libvolume_id now, and bump the major to 1, if the new (and correct)
> > naming is causing trouble?
> 
> You could keep using -version-info and pass 85:1:85 or 86:0:86. That
> would give you .so.0.85.1 or .so.0.86.0. That would keep the status
> quo for now and you could just follow the libtool rules from there:
> 
> http://www.gnu.org/software/libtool/manual/libtool.html#Updating-version-info
> 
> Once you decide to bump to .so.1, you could reset to 1:0:0 or
> something more in line with the "number of interfaces" concept in
> libtool.

Yeah, I removed the deprecated functions, and bumped the .so version
to 1.

Thanks,
Kay