linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-hotplug@vger.kernel.org
Subject: udev-129 compile error with --disable-logging
Date: Wed, 01 Oct 2008 21:16:32 +0000	[thread overview]
Message-ID: <200810012316.33324.zzam@gentoo.org> (raw)

Hi there!

It seems udev-129 has some log-related name conflicts when compiling udev 
configured with --disable-logging

libudev-ctrl.c: In function 'udev_ctrl_enable_receiving':
libudev-ctrl.c:104: error: called object 'log_null' is not a function
libudev-ctrl.c: In function 'ctrl_send':
libudev-ctrl.c:161: error: called object 'log_null' is not a function


The original source is this:
<<<<<<<<<<<<<<<<<<<<<<
int udev_ctrl_enable_receiving(struct udev_ctrl *uctrl)
{
        int err;
        const int feature_on = 1;

        err= bind(uctrl->sock, (struct sockaddr *)&uctrl->saddr, 
uctrl->addrlen);
        if (err < 0) {
                err(uctrl->udev, "bind failed: %m\n");
                return err;
        }

        /* enable receiving of the sender credentials */
        setsockopt(uctrl->sock, SOL_SOCKET, SO_PASSCRED, &feature_on, 
sizeof(feature_on));
        return 0;
}
<<<<<<<<<<<<<<<<<<<<<<

the pre-processor does change it to:

<<<<<<<<<<<<<<<<<<<<<<
int udev_ctrl_enable_receiving(struct udev_ctrl *uctrl)
{
 int log_null;
 const int feature_on = 1;

 log_null= bind(uctrl->sock, (struct sockaddr *)&uctrl->saddr, 
uctrl->addrlen);
 if (log_null < 0) {
  log_null(uctrl->udev, "bind failed: %m\n");
  return log_null;
 }


 setsockopt(uctrl->sock, 1, 16, &feature_on, sizeof(feature_on));
 return 0;
}
<<<<<<<<<<<<<<<<<<<<<<

So I think it will help to rename the err variable to any other name.

Regards
Matthias

             reply	other threads:[~2008-10-01 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01 21:16 Matthias Schwarzott [this message]
2008-10-02  4:24 ` udev-129 compile error with --disable-logging Kay Sievers
2008-10-02 17:00 ` Matthias Schwarzott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810012316.33324.zzam@gentoo.org \
    --to=zzam@gentoo.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).