udev-129 compile error with --disable-logging

udev-129 compile error with --disable-logging

[Matthias Schwarzott]

Hi there!

It seems udev-129 has some log-related name conflicts when compiling udev 
configured with --disable-logging

libudev-ctrl.c: In function 'udev_ctrl_enable_receiving':
libudev-ctrl.c:104: error: called object 'log_null' is not a function
libudev-ctrl.c: In function 'ctrl_send':
libudev-ctrl.c:161: error: called object 'log_null' is not a function


The original source is this:
<<<<<<<<<<<<<<<<<<<<<<
int udev_ctrl_enable_receiving(struct udev_ctrl *uctrl)
{
        int err;
        const int feature_on = 1;

        err= bind(uctrl->sock, (struct sockaddr *)&uctrl->saddr, 
uctrl->addrlen);
        if (err < 0) {
                err(uctrl->udev, "bind failed: %m\n");
                return err;
        }

        /* enable receiving of the sender credentials */
        setsockopt(uctrl->sock, SOL_SOCKET, SO_PASSCRED, &feature_on, 
sizeof(feature_on));
        return 0;
}
<<<<<<<<<<<<<<<<<<<<<<

the pre-processor does change it to:

<<<<<<<<<<<<<<<<<<<<<<
int udev_ctrl_enable_receiving(struct udev_ctrl *uctrl)
{
 int log_null;
 const int feature_on = 1;

 log_null= bind(uctrl->sock, (struct sockaddr *)&uctrl->saddr, 
uctrl->addrlen);
 if (log_null < 0) {
  log_null(uctrl->udev, "bind failed: %m\n");
  return log_null;
 }


 setsockopt(uctrl->sock, 1, 16, &feature_on, sizeof(feature_on));
 return 0;
}
<<<<<<<<<<<<<<<<<<<<<<

So I think it will help to rename the err variable to any other name.

Regards
Matthias

Re: udev-129 compile error with --disable-logging

[Kay Sievers]

On Wed, Oct 1, 2008 at 11:16 PM, Matthias Schwarzott <zzam@gentoo.org> wrote:
> It seems udev-129 has some log-related name conflicts when compiling udev
> configured with --disable-logging
>
> libudev-ctrl.c: In function 'udev_ctrl_enable_receiving':
> libudev-ctrl.c:104: error: called object 'log_null' is not a function
> libudev-ctrl.c: In function 'ctrl_send':
> libudev-ctrl.c:161: error: called object 'log_null' is not a function

Oh, bad. I've changed:
  define err log_null
to:
  define err(udev, arg...) log_null(udev, ## arg)
now, which should do the trick. It's here:
  http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h÷b148cde2a8ca6dc32af2e1d95824ac3be926db

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: udev-129 compile error with --disable-logging

[Matthias Schwarzott]

On Donnerstag, 2. Oktober 2008, Kay Sievers wrote:
> On Wed, Oct 1, 2008 at 11:16 PM, Matthias Schwarzott <zzam@gentoo.org> 
wrote:
> > It seems udev-129 has some log-related name conflicts when compiling udev
> > configured with --disable-logging
> >
> > libudev-ctrl.c: In function 'udev_ctrl_enable_receiving':
> > libudev-ctrl.c:104: error: called object 'log_null' is not a function
> > libudev-ctrl.c: In function 'ctrl_send':
> > libudev-ctrl.c:161: error: called object 'log_null' is not a function
>
> Oh, bad. I've changed:
>   define err log_null
> to:
>   define err(udev, arg...) log_null(udev, ## arg)
> now, which should do the trick. It's here:
>  
> http://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;hÖb148cde2a8
>ca6dc32af2e1d95824ac3be926db
>
Works now, thanks.

Matthias