From mboxrd@z Thu Jan  1 00:00:00 1970
From: md@Linux.IT (Marco d'Itri)
Date: Sun, 26 Apr 2009 19:54:58 +0000
Subject: udev: gpio-keys input driver should have class kbd
Message-Id: <20090426195457.GF32500@bongo.bofh.it>
MIME-Version: 1
Content-Type: multipart/mixed; boundary="LyciRD1jyfeSSjG0"
List-Id: <linux-hotplug.vger.kernel.org>
To: linux-hotplug@vger.kernel.org


--LyciRD1jyfeSSjG0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Is this reasonable?

----- Forwarded message from Frans Pop <elendil@planet.nl> -----

=46rom: Frans Pop <elendil@planet.nl>
To: udev@packages.debian.org
Subject: udev: gpio-keys input driver should have class kbd

clone 524505 -1
reassign -1 udev 0.140-1
retitle -1 udev: gpio-keys input driver should have class kbd
severity -1 wishlist
block 524505 by -1
thanks

With udev 0.140 (or rather: sometime after 0.125) we've lost the=20
persistent device symlink /dev/input/by-path/platform-gpio-keys-event-=20
due to the following change in 60-persistent-input.rules which no longer=20
allows an empty ID_CLASS:

-KERNEL=3D=3D"event*", ENV{ID_PATH}=3D=3D"?*", \
+KERNEL=3D=3D"event*", ENV{ID_PATH}=3D=3D"?*", ENV{ID_CLASS}=3D=3D"?*", \
        SYMLINK+=3D"input/by-path/$env{ID_PATH}-event-$env{ID_CLASS}"

This means that qcontrol in Debian unstable is now broken (see:=20
http://bugs.debian.org/524505).

It seems to me that the simplest solution is to let udev define a class=20
for gpio-keys (kbd seems most logical), for example with the following=20
change in 60-persistent-input.rules:

-DRIVERS=3D=3D"atkbd",                      ENV{ID_CLASS}=3D"kbd"
+DRIVERS=3D=3D"atkbd|gpio-keys",            ENV{ID_CLASS}=3D"kbd"

We can then adjust qcontrol to use the new persistent device link.

If that change is acceptable, please also push it for udev upstream.

Thanks,
FJP

----- End forwarded message -----

--=20
ciao,
Marco

--LyciRD1jyfeSSjG0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkn0vBEACgkQFGfw2OHuP7FlBwCfeq7IBphi5IJKyx5Q34Hai4HY
78IAoJBPH2sv0ZPqHNscS9QTLgO3Zyq4
=KVMB
-----END PGP SIGNATURE-----

--LyciRD1jyfeSSjG0--