From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Schwarzott Date: Mon, 25 May 2009 08:33:08 +0000 Subject: Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as interface name Message-Id: <200905251033.09272.zzam@gentoo.org> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Cc: Stefan Richter , Christian Kujau , linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, netdev@vger.kernel.org On Sonntag, 24. Mai 2009, Stefan Richter wrote: > Christian Kujau wrote at LKML: > > If the patch will be accepted at all and it's not too late to ask: I'd > > vote for fw%d as well, "firefire" just looks too long, for me at least. > > I think I'll leave the driver as it is. > As I just noticed, we would lose interface renaming by udev. > From udev/extras/rule_generator/75-persistent-net-generator.rules: > > # device name whitelist > KERNEL!="eth*|ath*|wlan*[0-9]|msh*|ra*|sta*|ctc*|lcs*|hsi*", > GOTO="persistent_net_generator_end" > > Besides, if we can we should avoid fw%d because this will clash with > udev rules which match KERNEL="fw*", as in > udev/rules/redhat/40-redhat.rules. I suggest a subsystem match here, or generally some SUBSYSTEM!="net", GOTO="end_of_file" around almost all rule files that should not match on network interfaces, as users can rename them to almost all crazy names. @Kay: Perhaps it could simplify some rulesets to have a special jump target or option to skip entiere rules files. Regards Matthias