From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 24 Aug 2009 17:50:02 +0000
Subject: Re: [PATCH] fix util_lookup_group to handle large groups
Message-Id: <20090824175002.GA1413@tango.0pointer.de>
List-Id: <linux-hotplug.vger.kernel.org>
References: <m1skgcjea5.fsf@fess.ebiederm.org>
In-Reply-To: <m1skgcjea5.fsf@fess.ebiederm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-hotplug@vger.kernel.org

On Mon, 24.08.09 18:50, Ansgar Johannes Pflipsen (pflipsen@ti.rwth-aachen.de) wrote:

> 		errno = 0;
> 		getgrnam_r(group, &grbuf, buf, buflen, &gr);
> 		if (gr != NULL)
> 			gid = gr->gr_gid;
> 		else if (errno = ERANGE) {
> 			buflen *= 2;	<<-- 0 * 2 = 0
> 			continue;
> 		}

One little comment here: on POSIX getrnam_r() doesn't touch
errno. Instead it returns the error value as return value.

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4