From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lennart Poettering Date: Tue, 29 Sep 2009 23:31:24 +0000 Subject: Re: [PATCH] Add compressed ID database support to (usb|pci)-db Message-Id: <20090929233124.GA10757@tango.0pointer.de> List-Id: References: <4AB83999.1060004@unitednerds.org> In-Reply-To: <4AB83999.1060004@unitednerds.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, 29.09.09 19:04, David Zeuthen (david@fubar.dk) wrote: > FWIW, this thing came up a couple of years ago on the hal list and back > then I very strongly refused to support compressed ids files. Mostly on > the grounds that it makes it impossible to mmap the files. E.g. you need > to allocate memory for the uncompressed image. > > In udev this is even worse because we'd be doing all this work over and > over again - for every freaking event. In HAL, we mmaped the ids files > at start-up, built a simple look-up table and did binary lookups on > every event. > > Just so you know, I'm still very much against this and I think it would > be a mistake to support compressed ids files in in udev. Please don't do > it. Ok, that makes sense to me. Sorry, Piter, it is unlikely that we will merge your patch. Even though your work will not be merged it is really appreciated! Sorry, Lennart -- Lennart Poettering Red Hat, Inc. lennart [at] poettering [dot] net http://0pointer.net/lennart/ GnuPG 0x1A015CC4