linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Pitt <martin.pitt@ubuntu.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: Adding input_id to udev
Date: Mon, 30 Nov 2009 19:27:03 +0000	[thread overview]
Message-ID: <20091130192703.GC2517@piware.de> (raw)
In-Reply-To: <20091130095715.GA2440@piware.de>

[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]

Martin Pitt [2009-11-30 10:57 +0100]:
> Questions:
> 
>  * Should we maintain this in udev proper, in extras/input_id/ ? (My
>    preferred solution, since it's not really X.org specific). I'm up
>    for maintaining it.

I discussed that on IRC with Kay today, and committed this to udev
trunk now.

>  * Should udev itself install rules which call this, or should we just
>    provide it for other packages to use? Calling it in udev itself
>    feels a little more robust to me, but it would mean that the
>    probing would be done in vain on systems which use X.org with hal.

It is in udev itself now, since it also helped to clean up
/lib/udev/rules.d/60-persistent-input.rules (look at the nice joystick
detection rule...).

I also made the following changes compared to the version of the
original mail:

 * Works on "eventN" (and similar) devices now, not on the parent
   "inputN" device. This is where you usually need them (in
   60-persistent-input.rules as well as X.org)

 * Argument should not specify /sys/ prefix any more, to be consistent
   to other probers, and for just using "input_id %p"

With those, the xorg rules do not need to jump through hoops to grab
the parent device's properties any more, and can just say

   ENV{ID_INPUT_KEY}=="*?", IMPORT{file}="/etc/default/keyboard"

or

   ENV{ID_INPUT_TOUCHPAD}=="1", ENV{x11_driver}="synaptics"

(The latter won't be used literally, since we still have some quirks,
but the structure is still easier than in the originally announced
rules.)

So now this needs to trickle into the distros, before X.org can rely
on it.

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

      parent reply	other threads:[~2009-11-30 19:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30  9:57 Adding input_id to udev Martin Pitt
2009-11-30 13:42 ` Dan Nicholson
2009-11-30 19:27 ` Martin Pitt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091130192703.GC2517@piware.de \
    --to=martin.pitt@ubuntu.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).