From mboxrd@z Thu Jan  1 00:00:00 1970
From: Martin Pitt <martin.pitt@ubuntu.com>
Date: Mon, 14 Dec 2009 12:45:43 +0000
Subject: Re: [PATCH] keymap: support for force_release quirk
Message-Id: <20091214124543.GA2039@piware.de>
MIME-Version: 1
Content-Type: multipart/mixed; boundary="5mCyUwZo2JvN/JJP"
List-Id: <linux-hotplug.vger.kernel.org>
References: <20091214001219.GA17792@sig21.net>
In-Reply-To: <20091214001219.GA17792@sig21.net>
To: linux-hotplug@vger.kernel.org


--5mCyUwZo2JvN/JJP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Johannes,

Johannes Stezenbach [2009-12-14 13:37 +0100]:
> I don't understand.  I only append to the force_release attribute
> because the kernel already removes duplicates.

Oh, indeed it does:

$ cat /sys/devices/platform/i8042/serio0/force_release
133-139,143,147,369-370

$ echo '133-139,143,147,369-370,143,147,370,371,147,371' | sudo tee /sys/de=
vices/platform/i8042/serio0/force_release
$ cat /sys/devices/platform/i8042/serio0/force_release
133-139,143,147,369-371

So indeed we then don't need to worry about sending duplicate keys.
Nice!

> However, what does not work this way is to remove scancodes from
> force_release. I thought that was what Martin wanted to accomplish
> on the "change" event.

Hm, it seems to work just fine here:

$ echo 133 | sudo tee /sys/devices/platform/i8042/serio0/force_release133
$ cat /sys/devices/platform/i8042/serio0/force_release
133

So it seems every time you write the file you have to do it completely
(or read the original one).

So I think your approach is fine after all, and we just need the other
small cleanups.

Thanks,

Martin

--=20
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

--5mCyUwZo2JvN/JJP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAksmM3QACgkQDecnbV4Fd/KH5QCeMt3N4/Aq2fmjncAmQGs2LwMR
aVwAoLXG0XkJU27FedE+5iSVdYoYlsv9
=ylzs
-----END PGP SIGNATURE-----

--5mCyUwZo2JvN/JJP--