From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Pitt Date: Mon, 21 Dec 2009 14:17:09 +0000 Subject: CK.OpenSession(): Do not block on run-seat.d scripts? Message-Id: <20091221141709.GA2268@piware.de> MIME-Version: 1 Content-Type: multipart/mixed; boundary="qDbXVdCdHGoSgWSk" List-Id: To: linux-hotplug@vger.kernel.org --qDbXVdCdHGoSgWSk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello William, I am currently investigating boot speed improvements, and one particular item is that gdm hangs half a second in ConsoleKit.OpenSession(). The reason is that it synchronously calls all run-seat.d/* scripts, which includes udev-acl.ck. I'm working on speeding up udev-acl.ck, but I need to discuss that with Kay Sievers first. However, I wondered why it is synchronous in the first place: The hooks are called with a couple of environment variables, but CK does not read any kind of result from them. In other words, the scripts can't influence session properties, nor abort the creation of a session. Is there a particular reason for CK to wait on all the hooks? If not, I'm happy to work on a patch to call those in the background. The only thing to watch out for, as far as I can see, is that a call to the hooks must not overlap with the next seat change, so this requires some locking. Thank you, and Merry Christmas, Martin --=20 Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org) --qDbXVdCdHGoSgWSk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAksvg2AACgkQDecnbV4Fd/J2SgCfeoiVyYFL7MGHMpF2pO42bkwH 0DEAoJ+/yqq5BhXBsP6SJbeXZSsUDXEO =E12F -----END PGP SIGNATURE----- --qDbXVdCdHGoSgWSk--