[PATCH] Fix reverted floppy-device permissions

[PATCH] Fix reverted floppy-device permissions

[Bryan Kadzban]

Commit d93fb59c50a720e2a1ace2177cc824c00ff8eed6 ("rules: set mode of
floppy device nodes to 0660") changed the create_floppy_devices -M
argument to 0660, for udev-148.

Commit 78171d9549fafdfc1e29d30915104a3ad55e116b reverted this, when it
moved the call to create_floppy_devices out to another rules file, for
udev-150.

Presumably the 0660 mode was correct, and the 0640 reversion was not
intentional; this restores 0660.

Signed-off-by: Bryan Kadzban <bryan@kadzban.is-a-geek.net>

diff --git a/extras/floppy/60-floppy.rules b/extras/floppy/60-floppy.rules
index 3123bb5..53e4a9e 100644
--- a/extras/floppy/60-floppy.rules
+++ b/extras/floppy/60-floppy.rules
@@ -1,4 +1,4 @@
 # do not edit this file, it will be overwritten on update

 SUBSYSTEM="block", KERNEL="fd[0-9]", ACTION="add", ATTRS{cmos}="?*", ENV{CMOS_TYPE}="$attr{cmos}", \
-  RUN+="create_floppy_devices -c -t $env{CMOS_TYPE} -m %M -M 0640 -G floppy $root/%k"
+  RUN+="create_floppy_devices -c -t $env{CMOS_TYPE} -m %M -M 0660 -G floppy $root/%k"

Re: [PATCH] Fix reverted floppy-device permissions

[Martin Pitt]

Hey Bryan,

Bryan Kadzban [2010-01-10 17:02 -0800]:
> Commit d93fb59c50a720e2a1ace2177cc824c00ff8eed6 ("rules: set mode of
> floppy device nodes to 0660") changed the create_floppy_devices -M
> argument to 0660, for udev-148.
> 
> Commit 78171d9549fafdfc1e29d30915104a3ad55e116b reverted this, when it
> moved the call to create_floppy_devices out to another rules file, for
> udev-150.
> 
> Presumably the 0660 mode was correct, and the 0640 reversion was not
> intentional; this restores 0660.

Indeed, nice catch. Applied.

Thank you!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)