Re: [PATCH] split --disable-extras into multiple options

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Mar 03, 2010 at 06:23:53AM -0800, Dan Nicholson wrote:
> I'm not that familiar with the udev setup, but I'd like to caution
> against surrounding these whole sections in an AM_CONDITIONAL. The
> preferred thing to do is surround just the parts that result in
> commands being run. For instance, I can see that you've here put
> dist_extras_gudev_libgudev_1_0_la_SOURCES under ENABLE_GUDEV. This
> will eventually break "make dist" if there person doing the
> distributing isn't building GUdev.

So you are saying, that if the section is disabled, then the files will be
skipped during "make dist", right?

So how would we handle "udevrules"?
"udevrulesdir" is always set but not all files in "dist_udevrules_DATA" are
always installed.
Would something like this work:

# unconditional stuff:
dist_udevrules_DATA += \
	some_file
...
dist_modem_modeswitch_DATA = \
	extras/modem-modeswitch/61-option-modem-modeswitch.rules \
	extras/modem-modeswitch/61-mobile-action.rules

if ENABLE_MODEM_MODESWITCH
udevrules_DATA += dist_modem_modeswitch_DATA

libexec_PROGRAMS += extras/modem-modeswitch/modem-modeswitch
endif # ENABLE_MODEM_MODESWITCH
...

Regards,
Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |