[PATCH] Fix Keymapping for upcoming Dell Laptops

[PATCH] Fix Keymapping for upcoming Dell Laptops

[Jerone Young]

Currently 0xD8 is being mapped to sleep. Though this is only done by the
Latitude XT* laptops. Many upcoming Laptops from Dell are mapping this
key to "toogle touchpad off" .. giving the OS notification that it has
just turned on the touchpad.

This patch fixes it so that new Dell machines will work correctly as
well as keep the Latitude XT working without issue. As well as adding
toogle touchpad ON keypress as well.

Signed-off-by: Jerone Young <jerone.young@canonical.com>

diff --git a/extras/keymap/95-keymap.rules b/extras/keymap/95-keymap.rules
index dd58453..af39c21 100644
--- a/extras/keymap/95-keymap.rules
+++ b/extras/keymap/95-keymap.rules
@@ -54,6 +54,7 @@ LABEL="keyboard_vendorcheck"
 
 ENV{DMI_VENDOR}="Dell*", RUN+="keymap $name dell"
 ENV{DMI_VENDOR}="Dell*", ATTR{[dmi/id]product_name}="Inspiron 1011", RUN+="keymap $name 0x84 wlan"
+ENV{DMI_VENDOR}="Dell*", ATTR{[dmi/id]product_name}="Latitude XT*", RUN+="keymap $name 0xD8 screenlock"
 
 ENV{DMI_VENDOR}="Compaq*", ATTR{[dmi/id]product_name}="*E500*|*Evo N*", RUN+="keymap $name compaq-e_evo"
 
diff --git a/extras/keymap/keymaps/dell b/extras/keymap/keymaps/dell
index 5ff44d6..aa1a7e1 100644
--- a/extras/keymap/keymaps/dell
+++ b/extras/keymap/keymaps/dell
@@ -23,5 +23,6 @@
 0x9B switchvideomode # Display Toggle button
 0xA2 playpause # Front panel play/pause
 0xA4 stopcd # Front panel stop
-0xD8 screenlock # FIXME: Tablet lock button
 0xED media # MediaDirect button
+0xD8 touchpadtoggle #toggle touchpad OFF 
+0xD9 touchpadtoggle #toogle touchpad ON

Re: [PATCH] Fix Keymapping for upcoming Dell Laptops

[Jerone Young]

I need to resubmit this patch as I put "touchpadtoggle" instead of f22.

			Jerone

On Wed, 2010-03-24 at 19:51 -0500, Jerone Young wrote:
> Currently 0xD8 is being mapped to sleep. Though this is only done by the
> Latitude XT* laptops. Many upcoming Laptops from Dell are mapping this
> key to "toogle touchpad off" .. giving the OS notification that it has
> just turned on the touchpad.
> 
> This patch fixes it so that new Dell machines will work correctly as
> well as keep the Latitude XT working without issue. As well as adding
> toogle touchpad ON keypress as well.
> 
> Signed-off-by: Jerone Young <jerone.young@canonical.com>
> 
> diff --git a/extras/keymap/95-keymap.rules b/extras/keymap/95-keymap.rules
> index dd58453..af39c21 100644
> --- a/extras/keymap/95-keymap.rules
> +++ b/extras/keymap/95-keymap.rules
> @@ -54,6 +54,7 @@ LABEL="keyboard_vendorcheck"
>  
>  ENV{DMI_VENDOR}="Dell*", RUN+="keymap $name dell"
>  ENV{DMI_VENDOR}="Dell*", ATTR{[dmi/id]product_name}="Inspiron 1011", RUN+="keymap $name 0x84 wlan"
> +ENV{DMI_VENDOR}="Dell*", ATTR{[dmi/id]product_name}="Latitude XT*", RUN+="keymap $name 0xD8 screenlock"
>  
>  ENV{DMI_VENDOR}="Compaq*", ATTR{[dmi/id]product_name}="*E500*|*Evo N*", RUN+="keymap $name compaq-e_evo"
>  
> diff --git a/extras/keymap/keymaps/dell b/extras/keymap/keymaps/dell
> index 5ff44d6..aa1a7e1 100644
> --- a/extras/keymap/keymaps/dell
> +++ b/extras/keymap/keymaps/dell
> @@ -23,5 +23,6 @@
>  0x9B switchvideomode # Display Toggle button
>  0xA2 playpause # Front panel play/pause
>  0xA4 stopcd # Front panel stop
> -0xD8 screenlock # FIXME: Tablet lock button
>  0xED media # MediaDirect button
> +0xD8 touchpadtoggle #toggle touchpad OFF 
> +0xD9 touchpadtoggle #toogle touchpad ON
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fix Keymapping for upcoming Dell Laptops

[Martin Pitt]

Hello Jerone,

Jerone Young [2010-03-24 20:00 -0500]:
> I need to resubmit this patch as I put "touchpadtoggle" instead of f22.
> [...]
> > +0xD8 touchpadtoggle #toggle touchpad OFF 
> > +0xD9 touchpadtoggle #toogle touchpad ON

Hm, your resubmitted patch does not contain those two at all any more.
Is the kernel default already correct for those two on newer Dells
then? Or were they just forgotten?

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

Re: [PATCH] Fix Keymapping for upcoming Dell Laptops

[Jerone Young]

I left them out on purpose in the resubmit. It turned out that the way
these work (currently) under Windows is that the key press does two
things.
	- it turns off the touchpad through the bios
	- it sends the keypress scan code to the OS

Under Windows the driver/daemon catches the keypress but it's only so it
can show a nice on screen display. Doesn't try to cut it off or on via
the OS.

Currently (working to fix with Dell), If these are mapped under Linux
what happens is. The hardware first cutoff the touchpad, but then what
happens is the software will then toggle this setting. So you end up in
one of two states:
		- never being able to turn off the touchpad
		- never being able to turn on the touchpad

Will submit another patch with these once can get this sorted out.

				Thanks,
					Jerone

On Thu, 2010-03-25 at 08:34 +0100, Martin Pitt wrote:
> Hello Jerone,
> 
> Jerone Young [2010-03-24 20:00 -0500]:
> > I need to resubmit this patch as I put "touchpadtoggle" instead of f22.
> > [...]
> > > +0xD8 touchpadtoggle #toggle touchpad OFF 
> > > +0xD9 touchpadtoggle #toogle touchpad ON
> 
> Hm, your resubmitted patch does not contain those two at all any more.
> Is the kernel default already correct for those two on newer Dells
> then? Or were they just forgotten?
> 
> Thanks,
> 
> Martin

Re: [PATCH] Fix Keymapping for upcoming Dell Laptops

[Martin Pitt]

Hello Jerone,

Jerone Young [2010-03-25  8:28 -0500]:
> Currently (working to fix with Dell), If these are mapped under Linux
> what happens is. The hardware first cutoff the touchpad, but then what
> happens is the software will then toggle this setting. So you end up in
> one of two states:
> 		- never being able to turn off the touchpad
> 		- never being able to turn on the touchpad

Thanks for the followup. So yes, let's ignore those keys for now.

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)