From: Martin Pitt <martin.pitt@ubuntu.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] Fix cdrom profile enumeration.
Date: Thu, 15 Apr 2010 06:43:16 +0000 [thread overview]
Message-ID: <20100415064315.GA2085@piware.de> (raw)
In-Reply-To: <1271214432-30088-1-git-send-email-mike@brudevold.com>
Hello Mike,
mike@brudevold.com [2010-04-14 20:38 -0500]:
> - for (i = 12; i < profiles[11]; i += 4) {
> + profiles_end = 12 + profiles[11];
> + for (i = 12; i < profiles_end; i += 4) {
(This could just be written as "i < 12 + profiles[11]" for simplicity)
Do you have some pointers which document this structure, in particular
whether it's really the count and not the last offset? I searched for
some minutes, but didn't find anything. It would be nice to add a
reference to the spec to the code.
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
next prev parent reply other threads:[~2010-04-15 6:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 3:07 [PATCH] Fix cdrom profile enumeration mike
2010-04-15 1:38 ` mike
2010-04-15 6:43 ` Martin Pitt [this message]
2010-04-15 13:42 ` Mike Brudevold
2010-04-15 18:15 ` Kay Sievers
2010-04-16 1:03 ` Mike Brudevold
2010-04-16 5:45 ` Kay Sievers
2010-04-16 23:05 ` Mike Brudevold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415064315.GA2085@piware.de \
--to=martin.pitt@ubuntu.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).