From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Pitt Date: Thu, 15 Apr 2010 06:43:16 +0000 Subject: Re: [PATCH] Fix cdrom profile enumeration. Message-Id: <20100415064315.GA2085@piware.de> List-Id: References: <1271214432-30088-1-git-send-email-mike@brudevold.com> In-Reply-To: <1271214432-30088-1-git-send-email-mike@brudevold.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Hello Mike, mike@brudevold.com [2010-04-14 20:38 -0500]: > - for (i = 12; i < profiles[11]; i += 4) { > + profiles_end = 12 + profiles[11]; > + for (i = 12; i < profiles_end; i += 4) { (This could just be written as "i < 12 + profiles[11]" for simplicity) Do you have some pointers which document this structure, in particular whether it's really the count and not the last offset? I searched for some minutes, but didn't find anything. It would be nice to add a reference to the spec to the code. Thanks, Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)